Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a context menu takes 1-2 secs when project is not hosted on github #420

Closed
0xd4d opened this issue Jul 6, 2016 · 3 comments
Closed

Opening a context menu takes 1-2 secs when project is not hosted on github #420

0xd4d opened this issue Jul 6, 2016 · 3 comments
Labels
bug

Comments

@0xd4d
Copy link

@0xd4d 0xd4d commented Jul 6, 2016

Version: 2.0 Beta 1
VS Version: VS 2015 Update 3

  1. Create a project and host it on eg. bitbucket.com
  2. Open project in VS
  3. Right-click in a source file

Expected Behavior:

Context menu opens immediately

Actual Behavior:

Context menu is shown after 1-2 seconds.

The reason is that the extension gets NotFound result back from the server.

If the extension is only meant to support github.com, then perhaps it should ignore any other sites.
@shana
Copy link
Collaborator

@shana shana commented Jul 6, 2016 •
edited

@0x4d4 Thank you so much for the report! We support enterprise github instances as wel, which are not hosted on github.com, so we can't rely on urls alone. The context menus should be timing our early though, to not block the UI, it should only be delaying things for 250ms at most. We'll look into it!
@grokys grokys added the bug label Jul 14, 2016
@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Sep 25, 2016

I debugged this scenario, I'm not sure if the bug existed previously, but currently I can confirm the IsGitHubDotComUri function is working correctly. Otherwise, if there is a connection error, the context menu won't be delayed longer than 250ms.
@grokys
Copy link
Contributor

@grokys grokys commented Feb 15, 2017

I too am unable to reproduce this in the latest version of the extension, so closing. @0xd4d please re-open if you're still having this problem.
@grokys grokys closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@shana @StanleyGoldman @0xd4d @grokys
You can’t perform that action at this time.