summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorMarius Strobl <marius@FreeBSD.org>2010-01-15 15:47:31 +0000
committerMarius Strobl <marius@FreeBSD.org>2010-01-15 15:47:31 +0000
commitb0088fdadc5b51e2f9e263a78aa3817ebc9774fd (patch)
tree1f90c8a2aa45f6b36206b684d9af6e7143427736 /sys/dev
parentd023fdb252b05146c545d837d7639412c66db09a (diff)
MFC: r201005, r201371
- Take advantage of bus_{read,write}_*(9). - Set dow = -1 in mk48txx_gettime() because some drivers (for example the NetBSD and OpenBSD mk48txx(4)) don't set it correctly.
Notes
svn path=/stable/7/; revision=202385
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/mk48txx/mk48txx.c13
-rw-r--r--sys/dev/mk48txx/mk48txxvar.h3
2 files changed, 12 insertions, 4 deletions
diff --git a/sys/dev/mk48txx/mk48txx.c b/sys/dev/mk48txx/mk48txx.c
index ec8a1e9b1751..9742e82748c8 100644
--- a/sys/dev/mk48txx/mk48txx.c
+++ b/sys/dev/mk48txx/mk48txx.c
@@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$");
#include <sys/eventhandler.h>
#include <sys/lock.h>
#include <sys/mutex.h>
+#include <sys/rman.h>
#include <sys/watchdog.h>
#include <machine/bus.h>
@@ -175,8 +176,16 @@ mk48txx_gettime(device_t dev, struct timespec *ts)
ct.min = FROMBCD(FROMREG(MK48TXX_IMIN, MK48TXX_MIN_MASK));
ct.hour = FROMBCD(FROMREG(MK48TXX_IHOUR, MK48TXX_HOUR_MASK));
ct.day = FROMBCD(FROMREG(MK48TXX_IDAY, MK48TXX_DAY_MASK));
+#if 0
/* Map dow from 1 - 7 to 0 - 6; FROMBCD() isn't necessary here. */
ct.dow = FROMREG(MK48TXX_IWDAY, MK48TXX_WDAY_MASK) - 1;
+#else
+ /*
+ * Set dow = -1 because some drivers (for example the NetBSD and
+ * OpenBSD mk48txx(4)) don't set it correctly.
+ */
+ ct.dow = -1;
+#endif
ct.mon = FROMBCD(FROMREG(MK48TXX_IMON, MK48TXX_MON_MASK));
year = FROMBCD(FROMREG(MK48TXX_IYEAR, MK48TXX_YEAR_MASK));
year += sc->sc_year0;
@@ -266,7 +275,7 @@ mk48txx_def_nvrd(device_t dev, int off)
struct mk48txx_softc *sc;
sc = device_get_softc(dev);
- return (bus_space_read_1(sc->sc_bst, sc->sc_bsh, off));
+ return (bus_read_1(sc->sc_res, off));
}
static void
@@ -275,7 +284,7 @@ mk48txx_def_nvwr(device_t dev, int off, uint8_t v)
struct mk48txx_softc *sc;
sc = device_get_softc(dev);
- bus_space_write_1(sc->sc_bst, sc->sc_bsh, off, v);
+ bus_write_1(sc->sc_res, off, v);
}
static void
diff --git a/sys/dev/mk48txx/mk48txxvar.h b/sys/dev/mk48txx/mk48txxvar.h
index 5bb92da2a63e..9706d8dbc942 100644
--- a/sys/dev/mk48txx/mk48txxvar.h
+++ b/sys/dev/mk48txx/mk48txxvar.h
@@ -35,8 +35,7 @@ typedef uint8_t (*mk48txx_nvrd_t)(device_t dev, int off);
typedef void (*mk48txx_nvwr_t)(device_t dev, int off, uint8_t v);
struct mk48txx_softc {
- bus_space_tag_t sc_bst; /* bus space tag */
- bus_space_handle_t sc_bsh; /* bus space handle */
+ struct resource *sc_res;/* bus resource */
struct mtx sc_mtx; /* hardware mutex */
eventhandler_tag sc_wet; /* watchdog event handler tag */