Skip to content

Session subclasses should honor the self.verify flag by default #404

Description

@smarie

I discovered this issue today while using Fiddler to debug my OAuth connection.

Each requests.Session object has a self.verify attribute stating if SSL certificates should be verified (for example to reject self-signed certificates).

Unfortunately, even if I set the attribute to False on an OAuth2Session object, this flag is not honoured because the default value is True (and not None) in fetch_token and refresh_token.
Note: it does not seem to happen with OAuth1Session objects.

I can provide a PR to fix this, it is extremely easy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions