gh-155322: Validate mutable structseq layout attributes - #155361
Open
BHUVANSH855 wants to merge 2 commits into
Open
gh-155322: Validate mutable structseq layout attributes#155361BHUVANSH855 wants to merge 2 commits into
BHUVANSH855 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a crash in heap-allocated
PyStructSequencetypes when the writablen_fieldsattribute is modified from Python before constructing a new instance.The constructor now validates member access using the actual
tp_membersarray instead of relying on the mutablen_fieldsattribute, preventing out-of-bounds access that could lead to a segmentation fault.Adds a regression test covering the reported crash.
Closes issue gh-155322.