Repository navigation
feat: add loadPolicySync - #255
Merged
Merged
Conversation
elliots
force-pushed
the
loadPolicySync
branch
2 times, most recently
from
August 27, 2022 07:04
b3ebf5e to
ece3b0c
Compare
Signed-off-by: Elliot Shepherd <elliot@jarofworms.com>
elliots
force-pushed
the
loadPolicySync
branch
from
August 27, 2022 07:06
ece3b0c to
344f175
Compare
srenatus
approved these changes
Aug 27, 2022
srenatus
left a comment
Contributor
There was a problem hiding this comment.
This is way above my skill set when it comes to js 😅 LGTM, thanks.
srenatus
reviewed
Aug 29, 2022
Contributor
|
@elliots thanks again. Do you need a release, or can you work with what's merged? 🙃 |
Contributor
Author
|
Cool. No rush, I'm vendoring it in the flutter component for now anyway. |
Contributor
|
Let us know what you come up with there! There's also https://github.com/anderseknert/awesome-opa#built-with-wasm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #251
Replacing loadPolicy with loadPolicySync in opa-test-cases.test.js gives the same number of pass/fails (and a little quicker?) but not sure you want to be testing both every time.
Added a browser test in a worker (loadPolicySync can't be used in main browser thread) and another small test.
Happy to hear any improvements or suggestions for tests.