CVS Repository/ src/ libexec/ login_chpass/ login_chpass.c

remove BACK_CHANNEL define, unused since YP bits removed in rev 1.20

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Delete YP password related code.  As a result, these can also be
pledged.  Keep an eye out for regressions, because they could be
uncomfortable.
ok beck semarie

No need to declare pwd_gensalt; it's unused and gone.
ok tedu@

use crypt_checkpass instead of doing things the hard way with crypt.

Use explicit_bzero() instead of memset() for zeroing out secrets.
OK deraadt@

remove some unnecessary sys/param.h inclusions

Foil potential timing attacks by using the correct password hash
instead of "xx".  In practice this means bcrypt() will be used for
non-existent users instead of DES crypt().
Adapted from a patch by Peter Philipp.  OK deraadt@

drop some krb4 stuff

ok beck@

pass lint

More checking for a NULL return value from getpass().  otto@ OK

Cleanup obsolete kerberos 4 stuff.

ok millert@

ansi; ok millert pvalchev

minor indent cleanup

minor KNF

pid_t cleanup

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Don't let root change it's password via login_l?chpass(8).
At some point in the future, passwd(1) may call these auth methods
at which time we will need a flag to allow root to do a password
change and also to allow account w/o a password to be given one.

o Use writev() to send status on the backchannel instead of fdopen()ing
  fd 3 and using stdio.

o Add SIGINT/SIGQUIT signal handler for yp_chpass() now that getpass()
  is interuptible.

o Block SIGINT/SIGQUIT in krb_chpass() until it is made to clean up
  after itself properly.

Do not set handler for SIGINT and SIGQUIT to SIG_IGN since it prevents
getpass()/readpassphrase() from being able to restore the tty mode
on keyboard interrupt.  Along with the recent readpassphrase.c commit
this means that if you ^C things that use login scripts (like su(1))
with a non-CBREAK shell your tty mode will be restored nicely.

TODO:
The various login scripts need to install handlers to avoid leaving
turd files or otherwise ending in a bad state.  It would also be
nice to send BI_REJECT to the back channel.

getopt(3) returns -1 when out of args, not EOF.

millert@ ok

chpass login script; changes local, yp, or kerberos password
will be used when BSD authentication is enabled