Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/signalfx-agent] Adding deprication notice - #13586

Merged
k8s-ci-robot merged 1 commit into
helm:masterfrom
EricLemieux:stable/signalfx-agent
May 9, 2019
Merged

[stable/signalfx-agent] Adding deprication notice#13586
k8s-ci-robot merged 1 commit into
helm:masterfrom
EricLemieux:stable/signalfx-agent

Conversation

@EricLemieux

@EricLemieux EricLemieux commented May 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding depreciation notice to the signalfx-agent readme

Signed-off-by: Eric Lemieux eric@lemieuxdev.com

What this PR does / why we need it:

This copy of the chart is out of date, and closed prs reference it as being deprecated (#12540).
This change just makes it clearer to new users where they can find the more up to date version.
I used the Istio deprecation notice, in the incubator/istio readme, as a model.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • title of the PR contains starts with chart name e.g. [stable/chart]
  • Update chart version

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2019
@k8s-ci-robot

k8s-ci-robot commented May 7, 2019

Copy link
Copy Markdown
Contributor

Hi @EricLemieux. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2019
@EricLemieux
EricLemieux force-pushed the stable/signalfx-agent branch from d7c2ea7 to a2bd5f4 Compare May 7, 2019 21:15
@EricLemieux

EricLemieux commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

/assign @lachie83

davidkarlsen
davidkarlsen suggested changes May 8, 2019
View reviewed changes
Comment thread stable/signalfx-agent/Chart.yaml
@davidkarlsen

davidkarlsen commented May 8, 2019

Copy link
Copy Markdown
Member

/assign

@EricLemieux
EricLemieux force-pushed the stable/signalfx-agent branch from a2bd5f4 to b391cd9 Compare May 8, 2019 23:49
cpanato
cpanato suggested changes May 9, 2019
View reviewed changes

@cpanato cpanato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the maintainers
Deprecated chart must not have maintainers

@EricLemieux
EricLemieux force-pushed the stable/signalfx-agent branch from b391cd9 to 1117d3f Compare May 9, 2019 12:37
@EricLemieux

EricLemieux commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

@cpanato I have removed the maintainer section, I didn't see that it needed to be removed in the docs.

@cpanato

cpanato commented May 9, 2019

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2019
@cpanato

cpanato commented May 9, 2019

Copy link
Copy Markdown
Member

@EricLemieux i wil update the docs thanks for the catch

@cpanato

cpanato commented May 9, 2019

Copy link
Copy Markdown
Member

@EricLemieux actually the item to remove the maintainers are describe here: https://github.com/helm/charts/blob/master/PROCESSES.md#deprecating-a-chart
item 4

cpanato
cpanato reviewed May 9, 2019
View reviewed changes
Comment thread stable/signalfx-agent/Chart.yaml Outdated
@EricLemieux
EricLemieux force-pushed the stable/signalfx-agent branch from 1117d3f to 9c3e6ec Compare May 9, 2019 13:40
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2019
@EricLemieux
[stable/signalfx-agent] Adding deprication notice
356250d 
Adding depreciation notice to the signalfx-agent readme

Signed-off-by: Eric Lemieux <eric@lemieuxdev.com>
@EricLemieux
EricLemieux force-pushed the stable/signalfx-agent branch from 9c3e6ec to 356250d Compare May 9, 2019 13:41
@EricLemieux

EricLemieux commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

@cparedes Apologies, I was following this doc https://github.com/helm/helm/blob/master/docs/charts.md#deprecating-charts

I have made the changes required in the doc you linked.

@davidkarlsen

davidkarlsen commented May 9, 2019

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@k8s-ci-robot

k8s-ci-robot commented May 9, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, EricLemieux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@k8s-ci-robot
k8s-ci-robot merged commit fa7b29f into helm:master May 9, 2019
stackedsax added a commit to stackedsax/charts that referenced this pull request May 12, 2019
@stackedsax
Merge remote-tracking branch 'upstream/master' into storm_chart
57d7eab 
* upstream/master: (4160 commits)
  [stable/mysql] support loadBalancerIP, configurationFilesPath (helm#13670)
  Allow setting an emptyDir sizeLimit for Prometheus (helm#12281)
  [stable/concourse] Add possibility to set strategy for rollingUpdates (web) (helm#13616)
  [stable/cluster-autoscaler] support dnsPolicy (helm#9029)
  [stable/rabbitmq-ha] allow setting different topology keys for anti affinity (helm#13635)
  [stable/airflow] Fix prometheusRule additionalLabels (helm#13683)
  [stable/postgresql] Set the right env. variable to enable debug (helm#13682)
  Use KUBERNETES_SERVICE_HOST environment variable (helm#13676)
  Enable new_k8s flag by default (helm#13618)
  [stable/prometheus-operator] Bump version dependency (helm#13625)
  [stable/odoo] Update Odoo dependencies (helm#13657)
  [stable/airflow] Add support for prometheus rules (helm#13662)
  [stable/signalfx-agent] Adding deprication notice (helm#13586)
  [stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC (helm#13495)
  stable/ambassador - Update to Ambassador 0.61.0 (helm#13661)
  [stable/redmine] Update Redmine dependencies (helm#13658)
  [stable/chart] Add deploymentStrategy on HackMD chart (helm#13645)
  [stable/grafana] Adds imagePullSecrets to test pod (helm#13574)
  [stable/k8s-dashboard] Clean up cluster-service label (helm#13545)
  [stable/postgresql] Fix 'mountPath' for password files. (helm#13653)
  ...
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@EricLemieux @goshlanguage
[stable/signalfx-agent] Adding deprication notice (helm#13586)
39992a4 
Adding depreciation notice to the signalfx-agent readme

Signed-off-by: Eric Lemieux <eric@lemieuxdev.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@EricLemieux @eyenx
[stable/signalfx-agent] Adding deprication notice (helm#13586)
2bd27eb 
Adding depreciation notice to the signalfx-agent readme

Signed-off-by: Eric Lemieux <eric@lemieuxdev.com>
@EricLemieux EricLemieux mentioned this pull request Jun 6, 2019
Closed
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@cpanato cpanato cpanato requested changes
@davidkarlsen davidkarlsen davidkarlsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@davidkarlsen davidkarlsen

@lachie83 lachie83

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EricLemieux @k8s-ci-robot @davidkarlsen @cpanato @lachie83 @helm-bot