Skip to content

Honor author trust in wrapped issue_read responses - #15292

Merged
lpcox merged 2 commits into
mainfrom
copilot/fix-difc-issue-read-filters
Oct 20, 2026
Merged

lpcox merged 2 commits into
mainfrom
copilot/fix-difc-issue-read-filters

Conversation

Copilot AI commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

issue_read labeled the outer {method, issue} envelope instead of the nested issue, assigning none:public despite trusted bot authorship. This filtered issue titles and bodies at min-integrity: approved.

  • Runtime: Extract the nested issue for issue_read/get before evaluating author trust; retain flat-response support.
  • Regression coverage: Add a sanitized affected-run fixture and real-WASM labeling/filtering tests for trusted authors, blocked-user and demotion precedence, and comment-author isolation.
  • Documentation: Clarify bot-login support and per-author trust boundaries.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue_read filters for github-actions[bot] Honor author trust in wrapped issue_read responses Oct 20, 2026
Copilot AI requested a review from lpcox October 20, 2026 19:08
@lpcox
lpcox marked this pull request as ready for review October 20, 2026 20:43
Copilot AI max review requested due to automatic review settings October 20, 2026 20:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human security sign-off is needed because the change affects trust labels controlling which issue content agents may read.

No open issues 🎉

What changed in this PR

Updates the GitHub guard so wrapped issue_read/get responses honor the nested issue author’s trust.

Changes:

  • Extracts nested issues while retaining flat-response support.
  • Adds regression coverage for trust precedence and comment-author isolation.
  • Clarifies bot trust and per-author boundaries.
File Description
internal/​proxy/​testdata/​issue_read_trusted_bot.json Adds a sanitized wrapped-response fixture.
internal/​proxy/​issue_read_guard_test.go Tests labeling and filtering through real WASM.
guards/​github-guard/​rust-guard/​src/​labels/​response_items.rs Extracts nested issues before labeling.
guards/​github-guard/​rust-guard/​src/​labels/​mod.rs Tests flat and wrapped trusted-bot responses.
docs/​CONFIGURATION.md Clarifies trust scope and precedence.

Review effort: Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DIFC: issue_read filters github-actions[bot] issue bodies despite approved trust policy

3 participants