Repository navigation
Honor author trust in wrapped issue_read responses - #15292
Merged
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue_read filters for github-actions[bot]
Honor author trust in wrapped issue_read responses
Oct 20, 2026
lpcox
marked this pull request as ready for review
October 20, 2026 20:43
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human security sign-off is needed because the change affects trust labels controlling which issue content agents may read.
No open issues 🎉
What changed in this PR
Updates the GitHub guard so wrapped issue_read/get responses honor the nested issue author’s trust.
Changes:
- Extracts nested issues while retaining flat-response support.
- Adds regression coverage for trust precedence and comment-author isolation.
- Clarifies bot trust and per-author boundaries.
| File | Description |
|---|---|
| internal/proxy/testdata/issue_read_trusted_bot.json | Adds a sanitized wrapped-response fixture. |
| internal/proxy/issue_read_guard_test.go | Tests labeling and filtering through real WASM. |
| guards/github-guard/rust-guard/src/labels/response_items.rs | Extracts nested issues before labeling. |
| guards/github-guard/rust-guard/src/labels/mod.rs | Tests flat and wrapped trusted-bot responses. |
| docs/CONFIGURATION.md | Clarifies trust scope and precedence. |
Review effort: Max
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue_readlabeled the outer{method, issue}envelope instead of the nested issue, assigningnone:publicdespite trusted bot authorship. This filtered issue titles and bodies atmin-integrity: approved.issue_read/getbefore evaluating author trust; retain flat-response support.