Java: remove duplicate query#6169
Closed
aibaars wants to merge 3 commits into
Closed
Conversation
smowton
requested changes
Jun 28, 2021
smowton
left a comment
Contributor
There was a problem hiding this comment.
I don't think that attribution is right: the query was duplicated in #5710 in order to add new sinks for experimental use only, defined in experimental/Security/CWE/CWE-078/JSchOSInjection.qll
In the medium term we should look at promoting those sinks; for now the experimental query should be given a fresh ID and comments added indicating it exists in order to test those experimental sinks.
Contributor
|
Suggest dropping this and replacing with #6170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query has been copied in 6bfc0af