Python: Promote ClickHouse SQL models - #5950
Merged
Merged
Conversation
This did reveal a few places where we do not detect the incoming SQL
This did turn into a few changes, that maybe could have been split into separate PRs 🤷 * Rename `ClickHouseDriver` => `ClickhouseDriver`, to better follow import name in `.qll` name * Rewrote modeling to use API graphs * Split modeling of `aioch` into separate `.qll` file, which does re-use the `getExecuteMethodName` predicate. I feel that sharing code between the modeling like this was the best approach, and stuck the `INTERNAL: Do not use.` labels on both modules. * I also added handling of keyword arguments (see change in .py files)
Member
Author
|
seems like stripping leading whitespace sneaked into my merge commit... I don't feel too sorry about that 😄 |
yoff
approved these changes
Jun 16, 2021
yoff
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I think splitting out aioch works well.
| } | ||
|
|
||
| /** `clickhouse_driver.Client` execute method names */ | ||
| string getExecuteMethodName() { result in ["execute_with_progress", "execute", "execute_iter"] } |
Contributor
There was a problem hiding this comment.
Very mildly annoyed with the ordering here.. :-)
| @@ -0,0 +1,2 @@ | |||
| import python | |||
| import experimental.meta.ConceptsTest | |||
Contributor
There was a problem hiding this comment.
Perhaps we should also promote this at some point..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.