From dc4bd73da1277cd32b442c1caccdad8261d3b994 Mon Sep 17 00:00:00 2001 From: Mathieu Arnold Date: Mon, 29 Jun 2015 15:32:11 +0000 Subject: Fixup a lot of Approved by: wblock (mentor) Differential Revision: https://reviews.freebsd.org/D2939 --- .../books/porters-handbook/makefiles/chapter.xml | 33 ++++++++++++---------- .../porters-handbook/slow-porting/chapter.xml | 2 +- .../books/porters-handbook/special/chapter.xml | 8 +++--- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml b/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml index 24850e53ee..f350074e07 100644 --- a/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml +++ b/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml @@ -3146,7 +3146,7 @@ ALWAYS_KEEP_DISTFILES= yes For example, RUN_DEPENDS= ${LOCALBASE}/news/bin/innd:${PORTSDIR}/news/inn \ -xmlcatmgr:${PORTSDIR}/textproc/xmlcatmgr + xmlcatmgr:${PORTSDIR}/textproc/xmlcatmgr will check if the file or directory /usr/local/news/bin/innd exists, and @@ -3502,9 +3502,9 @@ RUN_DEPENDS= ${MY_DEPENDS} .include <bsd.port.pre.mk> - .if exists(${LOCALBASE}/bin/foo) - LIB_DEPENDS= libbar.so:${PORTSDIR}/foo/bar - .endif +.if exists(${LOCALBASE}/bin/foo) +LIB_DEPENDS= libbar.so:${PORTSDIR}/foo/bar +.endif The problem with trying to automatically add dependencies @@ -3601,10 +3601,11 @@ PKGNAMESUFFIX= ${RESOLUTION} # default RESOLUTION?= 300 .if ${RESOLUTION} != 118 && ${RESOLUTION} != 240 && \ -${RESOLUTION} != 300 && ${RESOLUTION} != 400 -@${ECHO_MSG} "Error: invalid value for RESOLUTION: \"${RESOLUTION}\"" -@${ECHO_MSG} "Possible values are: 118, 240, 300 (default) and 400." -@${FALSE} + ${RESOLUTION} != 300 && ${RESOLUTION} != 400 +pre-everything:: + @${ECHO_MSG} "Error: invalid value for RESOLUTION: \"${RESOLUTION}\"" + @${ECHO_MSG} "Possible values are: 118, 240, 300 (default) and 400." + @${FALSE} .endif japanese/xdvi300 also has all @@ -3972,9 +3973,11 @@ FOO_CONFIGURE_ENABLE= foo Malformed conditional, an alternative syntax can be used. - .if !empty(VARIABLE:MVALUE) -# as an alternative to -.if ${VARIABLE:MVALUE} + .if !empty(VARIABLE:MVALUE) + + as an alternative to + + .if ${VARIABLE:MVALUE} @@ -4775,14 +4778,14 @@ PORTVERSION= 1.0 example: post-install: - ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xdl + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xdl When multiple files need to be stripped: post-install: - .for l in geometry media body track world - ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lib${PORTNAME}-${l}.so.0 - .endfor +.for l in geometry media body track world + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/lib${PORTNAME}-${l}.so.0 +.endfor Use &man.file.1; on a file to determine if it has been stripped. Binaries are reported by &man.file.1; as diff --git a/en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml b/en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml index 942fb7510a..26cc7fc9e0 100644 --- a/en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml +++ b/en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml @@ -408,7 +408,7 @@ variable: post-patch: - @${REINPLACE_CMD} -e 's|for Linux|for FreeBSD|g' ${WRKSRC}/README + @${REINPLACE_CMD} -e 's|for Linux|for FreeBSD|g' ${WRKSRC}/README Quite often, software being ported uses the CR/LF convention in source files. This may cause problems with diff --git a/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml b/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml index aa3fcf4a42..4ef04bc20a 100644 --- a/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml +++ b/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml @@ -1772,11 +1772,11 @@ PLIST_SUB+= QT_INCDIR=${QT_INCDIR_REL} \ This snippet demonstrates the use of qmake for a Qt 4 port: - USES= qmake:outsource + USES= qmake:outsource USE_QT4= moc_build For a Qt 5 port: - USES= qmake:outsource + USES= qmake:outsource USE_QT5= buildtools_build @@ -1795,8 +1795,8 @@ USE_QT5= buildtools_build include and library search paths via the command line, use: - QMAKE_ARGS+= INCLUDEPATH+=${LOCALBASE}/include \ - LIBS+=-L${LOCALBASE}/lib + QMAKE_ARGS+= INCLUDEPATH+=${LOCALBASE}/include \ + LIBS+=-L${LOCALBASE}/lib -- cgit v1.3