matrei commented on code in PR #1201:
URL: 
https://github.com/apache/grails-spring-security/pull/1201#discussion_r2794606213

##########
plugin-rest/spring-security-rest-testapp-profile/build.gradle:
##########
@@ -25,7 +25,7 @@ plugins {
 group = 'org.apache.grails.profiles'
 
 ext {
-    publishArtifactId = 'spring-security-rest-testapp'
+    publishArtifactId = 'spring-security-rest-testapp-profile'
     pomTitle = 'Grails Spring Security REST Plugin'
     pomDescription = 'Grails plugin to implement token-based, RESTful 
authentication using Spring Security'

Review Comment:
   Change title and description (or remove them if they are not mandatory for 
publishing).
   Right now it's confusing.



##########
plugin-rest/spring-security-rest-testapp-profile/features/data1/skeleton/grails-app/conf/application.yml:
##########
@@ -24,20 +24,20 @@ dataSource:
     driverClassName: org.h2.Driver
     username: sa
     password: ''
-
+    dialect: org.hibernate.dialect.H2Dialect

Review Comment:
   Is the dialect necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to