libutil: Make free_iovec() set iovlen to zero, like the manpage says
ClosedPublic
Actions

Authored by arrowd on Wed, Sep 23, 3:38 PM.

Details

Reviewers

kib
olce

Group Reviewers

Contributor Reviews (src)

Commits

rGe8da57256d79: libutil: Make free_iovec() zero its arguments, like the manpage claims

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77219
Build 74102: arc lint + arc unit

Event Timeline

arrowd created this revision.Wed, Sep 23, 3:38 PM

Herald added a reviewer: olce. · View Herald TranscriptWed, Sep 23, 3:38 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B77210: Diff 187506.Wed, Sep 23, 3:38 PM

arrowd requested review of this revision.Wed, Sep 23, 3:38 PM

Man page also claims that iov is set to NULL, but you did not do that.
Was there a reason for the change except the man page compliance?

Zero both args

Harbormaster completed remote builds in B77219: Diff 187527.Wed, Sep 23, 7:06 PM

Was there a reason for the change except the man page compliance?

Yes, the idea is to be able to reuse iov and iovlen right away after freeing previous ones:

build_iovec(&iov, &iovlen, ...);
build_iovec(&iov, &iovlen, ...);
...

free_iovec(&iov, &iovlen, ...);

build_iovec(&iov, &iovlen, ...);
build_iovec(&iov, &iovlen, ...);
...

Without this change one has to additionally put

iov = NULL;
iovlen = 0;

after free_iovec.

kib accepted this revision.Wed, Sep 23, 7:15 PM

This revision is now accepted and ready to land.Wed, Sep 23, 7:15 PM

Closed by commit rGe8da57256d79: libutil: Make free_iovec() zero its arguments, like the manpage claims (authored by arrowd). · Explain WhySat, Sep 26, 4:16 PM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: rGe8da57256d79: libutil: Make free_iovec() zero its arguments, like the manpage claims.

Revision Contents
Changeset List

Path

Size

lib/

libutil/

mntopts.c

2 lines

Diff 187527

View Options

libutil: Make free_iovec() set iovlen to zero, like the manpage saysClosedPublicActions