[12:00:42] arschmitz awayrxaviers jzaefferer [12:01:09] hi [12:01:54] oi [12:02:39] Felix's datepicker PR was finally merged! [12:02:39] https://github.com/jquery/jquery-ui/pull/1755 [12:03:19] A bit over a month :-) [12:03:33] I landed a bunch of other PRs too. [12:03:34] We're down to 9 open PRs. [12:03:42] Started out as improving tests, ended up with a lot more... [12:03:58] Unfortunately, I didn't have time to look into tickets. [12:04:29] Only 3 open PRs from this year... [12:05:44] Well, some of them are just stalled. Like the PEP and intern ones aren't things that can land and haven't been touched in forever. [12:06:02] yeah [12:06:09] This Triage report looks odd: https://bugs.jqueryui.com/query?status=new&type=bug&group=component&col=id&col=summary&col=version&report=30&order=id [12:06:55] I guess I just haven't looked at it in a long time [12:08:16] A lot of tickets just haven't been triaged. [12:08:51] 3 less :-) [12:09:07] arschmitz: Have you gotten a chance to look at any of the tickets? [12:09:33] I'm guessing that answer will be no. [12:09:40] i actually started looking at the datepicker one [12:09:43] with ios 10 [12:09:48] oh yeah? [12:09:50] but no answer to whats going on yet [12:09:53] ok [12:09:59] but its happening for sure lol [12:13:47] Nothing worth discussing came up in the past week, so having not made progress on any of the tickets, I don't think there's much to discuss today. [12:13:59] sorry, I'm late [12:14:06] Oh, hey fnagel. [12:14:13] Maybe you'll have some input on this selectmenu bug. [12:14:22] https://bugs.jqueryui.com/ticket/15091 [12:14:44] We're currently using `role="combobox"` but it looks like we should be using `role="listbox"` [12:14:51] But doing that seems non-trivial. [12:15:29] naahh, I'm not exactly sure, but I think this was a case of "specs says so, but that's not working in real world" [12:15:41] We discussed some details last week: http://irc.jquery.org/%23jquery-meeting/default_%23jquery-meeting_20161102.log.html#t12:10:03 [12:16:10] Yeah, so the question is does this actually cause issues for any users? [12:16:58] Maybe we can get input from TPG, Deque, or OCAD? [12:17:36] Ohh I missed last week becasue [12:18:40] Question #2: does using a combobox improve what we have? [12:20:35] Do you mean does using listbox improve what we have? [12:21:00] yeah sorry [12:21:50] Well, presumably just the use of the role will improve usability because users will know that they can't type arbitrary values. [12:27:33] Anything else to discuss today? [12:29:00] we might discuss calendar next steps [12:29:33] sure [12:31:07] just for the record: I'was not able to find any discussion yet, but this is the commit we added combox to the button https://github.com/jquery/jquery-ui/commit/4dbbd0598a58277816289441f3278a65025515d3 [12:31:49] This is still pending? Add calendar and datepicker to the requirejs task in the Gruntfile [12:32:21] Not sure, without looking into the code [12:33:34] Yup, still pending. [12:34:01] Do you want to look into that? It might be straight-forward now. [12:34:08] I'm guessing this was a holdover just because of the i18n files. [12:34:10] But those are gone. [12:34:45] I guess so [12:35:06] I'm trying right now. [12:35:23] What about "Think about parameter for callback events" and those little test issues like "Decide on how to date objects should be initialized within the tests" and "Add assertion that verifies where the focus should be" [12:35:33] Oh, here's something fairly easy. [12:35:34] Removing use of QUnit globals in tests. [12:35:40] I think there's a script we can run to do that. [12:36:51] What are the options for initializing date objects? [12:37:33] Writing focus tests seems like a good next step. [12:37:36] Options are with or without $month - 1 within the date constructor [12:37:50] Ah, I've grown to like the `- 1`. [12:38:00] hehe [12:38:10] good I've waited two year :-D [12:38:15] haha [12:39:57] jzaefferer: Do you know where the script is that replaces QUnit globals with the non-globals? [12:41:58] fnagel: Do focus tests sound good to you as a next step? [12:42:48] yes and no [12:43:17] a11y for multiple month is another probably not that tiny issue [12:43:37] event callbacks could be done before finalizing tests [12:43:41] Sure. I was thinking you'd start with just the focus tests for single month. [12:45:00] I'll spend some time today looking at the events. [12:46:16] Tests are actually not that bad at the moment, but I think its best to specify and implement a behaviour for both, single (done) and multiple (not yet) and than look into improving and adding tests [12:47:28] just to make sure: we stick to "month -1"? If so, I will remove the wiki item [12:47:35] yup [12:50:31] Anything else for today? [12:51:40] "Add assertion that verifies where the focus should be" [12:52:36] I think thats no longer relevant as the code has been removed : https://github.com/jquery/jquery-ui/pull/1430/files#r23173532 [12:53:10] scott_gonzalez: you mean this? https://github.com/apsdehal/qunit-migrate [12:53:23] Found the link here: http://qunitjs.com/upgrade-guide-2.x/ [12:54:10] yup [12:54:19] Ok, I will give it a try [12:54:20] That's the one. Thanks jzaefferer. [12:54:23] thanks [12:54:53] So focus doesn't actually move? [12:55:33] We just use ARIA attributes to indicate focus? [12:56:07] Nah, I guess the wiki item is not a good description what jörn wanted me to do. I will come up with something. [12:56:21] ok [13:00:41] I guess that's all for today. Thanks everyone. [13:01:04] Selectmenu button role=combox added to wiki: http://wiki.jqueryui.com/w/page-revisions/compare/12138056/Selectmenu?rev2=1327015996&rev1=1326995271 [13:01:11] Sadly without a WHY [13:02:41] oh well [13:02:56] I'll contact some people and see if we can get more info.