[12:00:53] arschmitz awayrxaviers fnagel jzaefferer [12:03:43] Anyone here? [12:05:23] yes sorr [12:05:30] just got a phone call of a client [12:05:39] no problem [12:06:07] arschmitz said he'll be another five minutes or so. He's stuck running errands right now. [12:06:39] There's been good progress on fnagel's datepicker PR: https://github.com/jquery/jquery-ui/pull/1755 [12:08:00] I need to do another round of review now that he has pushed updates. [12:09:14] I remembered that we don't have auto-closing pending tickets any more. [12:09:29] Tickets set to pending used to close after two weeks if there was no response from the reporter. [12:09:42] Since the Trac upgrade, we haven't had that functionality. [12:09:48] So I went through and closed the old pending tickets. [12:10:24] I'll ask Ryan Ollos (Trac core dev who has been helping us) if he can reimplement that functionality. [12:12:01] ok [12:12:09] I'm here now [12:12:59] Here now [12:14:35] arschmitz: Any progress on the datepicker iOS 10 bug? [12:18:57] Ha ha I just responded to this and totally the wrong channel not paying attention [12:19:35] And ensure no I didn't look at it I keep forgetting about that one I need to actually check my assigned tickets when I don't think I have anything to work on for UI [12:20:09] I'm terrible [12:20:44] ok [12:23:08] Custom Selectmenu with _renderItem crashes when calling "refresh": https://bugs.jqueryui.com/ticket/15075 [12:23:16] I haven't confirmed this yet. [12:25:56] http://jsbin.com/vuvara/edit?html,js,output [12:28:25] Oh, is this a 1.12 change for menu? [12:28:40] http://jqueryui.com/upgrade-guide/1.12/#require-wrappers-for-each-menu-item [12:28:46] yes i think thats it [12:29:18] http://jsbin.com/vuvara/1/edit?html,js,output [12:30:50] thats just mine? [12:31:28] weir [12:31:30] weird [12:31:42] nah, seems to crash when using the original _renderItem code too [12:31:47] I wonder why it didn't generate a new URL for the snapshot. [12:32:21] fnagel: does not for me [12:32:53] http://jsbin.com/xutanosipi/1/edit?html,js,output [12:32:57] So strange. It refuses to save mine. [12:32:59] I'll have to start over. [12:33:07] ok so this is when you extend selectmenu at all [12:33:48] because refresh is fine with original selectmenu widget [12:34:14] seems related to the widget itself [12:34:33] fnagel: weird [12:34:34] http://jsbin.com/vuvara/edit?html,js,output [12:34:41] that works fine [12:34:47] jep [12:34:54] http://jsbin.com/pufevezoja/1/edit?html,js,output [12:34:56] i dont get whats going on here [12:35:02] jsbin is having serious issues for me. [12:35:46] fnagel: yours and mine are identical as far as i can tell [12:35:50] but yours fails and mine works [12:36:10] something's wrong [12:36:41] fnagel's fails because he has reference errors. [12:36:49] oh $ul [12:36:50] yup [12:36:53] http://jsbin.com/pufevezoja/1/edit?html,js,output works now [12:36:55] He kept the function definition from the original [12:37:01] right [12:37:03] sorry [12:37:22] Anyway, http://jsbin.com/pufevezoja/1/edit?html,js,output has the minimal change to make it work. [12:37:33] ok so yes this is just the 1.12 menu wrapper issue [12:37:45] so not actually an issue [12:37:56] but maybe add it to the upgrade guide [12:38:24] specifically for selectmenu with custom rendering [12:40:29] https://github.com/jquery/api.jqueryui.com/pull/309 [12:46:01] https://github.com/jquery/jqueryui.com/pull/160 [12:48:25] Anyone have anything else to discuss? [12:50:54] just a question [12:51:13] any idea why the timezone issue hits now for datepicker / calendar branch but did not before? [12:51:30] seems strange to me, or do I miss something [12:51:59] Not sure. We've had plenty of timezone issues in the past though. [12:52:00] travis unit tests fail due to timezone issues (that the idea atm) [12:52:30] so, its probably caused by some change related to travis? [12:52:45] could be [12:52:52] ok [12:53:20] everything else in the PR [12:53:23] thanks! [12:54:24] Thanks everyone.