[12:04:45] ?uiteam [12:04:45] arschmitz fnagel jzaefferer mikesherov rxaviers_ scott_gonzalez tjvantoll [12:04:56] hey [12:06:22] We finally announced the beta! [12:06:24] http://blog.jqueryui.com/2016/01/jquery-ui-1-12-0-beta-1/ [12:06:34] Thanks to jzaefferer for fixing the quick download generation. [12:08:36] fnagel: Anything to discuss for datepicker? [12:08:44] Nope [12:09:13] hello [12:09:16] I'm back to looking at https://github.com/jquery/jquery-ui/pull/1548 [12:09:26] But I honestly don't know if we're handling this right. [12:09:49] I'm going to see if I can get a discussion going in #accessibility on Mozilla IRC after this meeting. [12:10:01] I tried earlier, but a lot of them are in meetings/eating lunch. [12:10:19] Can anyone think of a native equivalent to this? [12:10:30] The best I've come up with is dragging a window. [12:10:33] And that never moves focus. [12:10:48] I have to read the whole thing again, its been too long [12:11:22] There are a lot of specific scenarios that have been given in the past via bug reports. [12:12:00] But the whole thing boils down to: When mousing down on a draggable (or any other mouse-based element), should focus ever move, and if so, when and where? [12:13:26] #12472 (the ticket that the PR is supposed to fix) is specifically requesting that mousing down on a draggable handle *should* blur the active element when it's unrelated to the draggable. [12:13:43] But I'm not sure when that scenario would occur outside of a web page. [12:13:53] Or even within a web page using only native controls. [12:14:13] Trying to find precedence for the behavior. [12:23:03] Does anyone have anything else to discuss today? [12:29:37] I guess that's all for today. [13:02:20] zz_AurelioDeRosa, kswedberg, arthurvr, [13:02:32] good evening everyone! Meeting time :-) [13:02:34] Hey-hey! [13:03:00] and happy new year! since it's our 1st meeting in 2016 (and we're still in Jan :-) ) [13:03:04] Hey Arthur!!!!! [13:03:09] https://docs.google.com/document/d/10BtIFF5R_djDCAtwJQiIxy3oOxdQeyrogWFoSvybFHA/edit# [13:04:03] Are we alone here today? [13:04:12] looks like it.... [13:04:45] It would have been nice to discuss/approve https://github.com/jquery/api.jquery.com/pull/877 [13:04:58] Yeah. [13:05:49] about api.jquery.com, we’ll have to actually make every file tab indented before landing this, I guess? [13:05:57] A bunch of stuff isn’t atm [13:06:03] like https://github.com/jquery/api.jquery.com/blob/master/entries/attribute-contains-word-selector.xml and a bunch of other entries [13:06:14] scott_gonzalez: if you're still around, are you happy with https://github.com/jquery/api.jquery.com/pull/877 ? [13:06:38] arthurvr: oh, yes. [13:07:07] A few small things. [13:07:10] I'll comment on the PR. [13:07:21] scott_gonzalez: sure, that would be great, thank you [13:07:33] Yeah let’s discuss it there :) [13:07:45] arthurvr: can these be fixed afterwards? (entries with spaces?) [13:08:29] or will having the .editorconfig file cause issues? [13:09:07] I don’t think it’s really gonna be a problem, but it seems like something that should happen at the same time. [13:09:31] The files should be fixed. [13:09:54] scott_gonzalez: at the same time or can this be done afterwards? [13:10:02] It might be annoying when your editor switches to tabs automatically and you don’t want unrelated edits in a specific commit, so I think it’s better to fix those files right away. [13:10:02] Otherwise you'll end up with commits that mix indentation fixes (automatic by the editor) and actual changes. [13:10:17] right, ok, that's what I was wondering [13:10:37] I don't think there's a tool to fix indentation automatically from an editorconfig file. [13:10:50] so it's a manual process? [13:11:20] as you normally would? [13:11:24] Well, TBH, I've had mixed results with editorconfig. [13:11:35] I'm not sure how effective this actually is. [13:11:56] I'm all for tooling to solve annoying problem like this. [13:12:02] But it's getting out of hand. [13:12:06] But I digress... [13:12:26] so I was wondering whether we could just have the editorconfig file available for whoever wants to use it but we don't have to? [13:12:40] or if we have it in, we have to use it? [13:13:31] If someone has the editorconfig plugin it seems to me that it’s their intention to actually use it. If people don’t have the plugin it won’t apply anyway. [13:13:44] It's up to every individual contributor to use an editor that supports editorconfig (plus to install and enable the support). [13:14:06] To clarify, this is very different from things like JSHint and JSCS. [13:14:24] There is no editorconfig task that can be run to find or fix mistakes. [13:14:27] right. So my inderstanding is we're offering the file so that XO can contribute [13:14:32] You have to actually go through your editor. [13:14:58] and whoever else that has the same issue and a requirement for this file [13:15:43] so I can still carry on as normal and make my indetations manually, and fix spaces to tabs manually? [13:15:54] Is this correct? [13:16:41] The real issue is that this particular contributor has bad settings in their editor. [13:16:56] But this will fix their problem. [13:17:32] perfect. Ok, so actually all this can be done directly by changing settings in the editor? [13:17:40] yes [13:17:59] But I can tell you that this particular contributor will not do anything without the editorconfig file. [13:17:59] just like you or kswedberg changed my editor to remove trailing spaces [13:18:12] yes, [13:19:11] Getting back to the PR, kswedberg's comment seems unaddressed. [13:19:12] so I understand the issues about us having spaces in place sometimes and having to fix that. However, I don't see why it's important to fix this before we make the editorconfig avaialble [13:19:45] But don't let me hold this up. I don't work on this repo. [13:20:00] And there's not a whole lot of consensus across projects anymore. [13:20:47] Your view is important [13:21:00] so we could specify all file types to use tab? [13:21:12] yes I think so [13:21:36] except *.yml [13:21:42] and package.json [13:21:47] Right, except for *.yml and package.json [13:22:09] cool. Thanks a lot. [13:23:05] It's in the notes :-) [13:24:49] ok, next item: https://github.com/jquery/api.jquery.com/pull/530 [13:24:51] Thanks! [13:24:57] Oh yeah that issue. [13:25:05] It’s probably more something we should ask the core team. [13:25:14] Maybe we could ask timmy [13:26:01] I’ll see if I can attend the core meeting monday and ask them [13:26:46] or simply ping the ticket again [13:26:59] thanks, yes, I have lost Timmy's handle on irc... [13:27:03] timmywil? [13:27:03] ah, thanks :) [13:28:10] next item [13:28:10] https://github.com/jquery/api.jquery.com/pull/854 [13:28:31] so this comment: https://github.com/jquery/api.jquery.com/pull/854#issuecomment-167775764 [13:28:33] I think it's pretty clear: If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. [13:28:55] Sure but I wonder if it can be made more specific about the issue with the name/email [13:29:02] people sometimes don’t realise what exactly is wrong [13:29:30] I still have to make that kind of comments often [13:29:39] you mean we should say first name and last name as well as your email address [13:30:09] ? [13:31:02] I was thinking in the line of simply adding things like ”you’re mail doesn’t look like a normal mail address” or ”your git commit author information doesn’t contain a last name” [13:31:36] Might make things more clear [13:32:04] so you mean give an automatic specific error message? [13:32:14] yeah [13:32:44] not a big deal though [13:32:45] but if they enter jsut one name, we don't know whether this is their first or last name? [13:32:47] I simply thought it might save some time [13:33:47] or something like ”The git commit author information doesn’t contain two valid names (first and last name are required)” [13:34:23] might help pointing out the issue for people when they don’t see what’s wrong [13:34:43] yes, but I wonder whether this is the case everywhere in the world... (I seem to remember something about this but I am not sure....) I'll have to double check, maybe Scott would remember... [13:35:09] ah yeah there’s https://github.com/jquery/jquery-license/issues/54 [13:35:48] I forgot about it for a moment too [13:36:15] no worries :-) [13:36:18] still I wonder whether it can be made more clear in general, people seem to have troubles still [13:36:51] sure [13:37:19] I’ll look into it next time I see an issue with troubles and see if I can come up with more concrete suggestions [13:37:45] yes, that would be great [13:38:42] alright :) [13:39:43] finally https://github.com/jquery/learn.jquery.com/issues/690 [13:39:49] Yeah [13:40:02] I was wondering if anyone had seen this strange behaviour before? [13:41:26] I haven't noticed but I tend to type the urls [13:41:41] thanks for the comment :-) [13:42:12] Yeah, I just pinged the opener again. Let’s see and otherwise I’ll just forward that conversation to the infra or the wp-content repo. [13:42:24] sure, sounds good :-) [13:42:37] I've added your comment in the notes [13:43:04] I don't have anymore comments [13:43:12] any other issues? [13:43:20] not from me at least [13:43:40] I just wanted to say huge thanks as well to Aurelio for his crazy work recently :-) [13:44:13] but he's not here to hear it ;-) [13:44:26] Yeah, amazing work! Thanks! :) [13:44:38] ok, thanks a lot for everything arthur and the agenda! [13:45:26] ok, I think this is it for today and see you in 2 weeks! [13:45:30] Have a nice evening! :) [13:45:36] thanks, you too!