[09:00:08] arschmitz jperrault jzaefferer mikesherov rxaviers tj_vantoll [09:00:12] hello all [09:00:18] Hi [09:00:21] yo [09:00:46] Ticket and PR counts are still on the decline :-) [09:00:54] And mikesherov fixed the last 1.11.x regression. [09:01:11] I'd like to do a 1.11.3 release soon. [09:01:19] Whenever I'm not slammed with other tasks ;-) [09:01:41] We have a good amount of bug fixes that can be cherry-picked to 1-11-stable. [09:01:49] And some of them are pretty important fixes. [09:03:28] arschmitz: Anything that needs to be discussed for classes? [09:03:50] Well probably worth mentioning i added 2 custom assertions to testsuite [09:03:57] hasClasses and lacksClasses [09:04:23] for testing if elements have ( or dont have ) any number of classes [09:04:36] and im updating ALL the tests to use these consistently [09:04:51] just about done and will push another update to classes [09:05:16] assert.has/lacksClasses( element, classes) [09:05:31] and classes is just a spaced separated string of classes [09:06:11] this is to finnally settle many hasClass / attr( "class" / is( ".class.class2" ) [09:06:43] yay [09:06:54] and it gives actual usable diff [09:07:37] 5 minutes delay, but I’m here :) [09:07:42] its actually a really nice improvement in many of the test files [09:07:48] I'm sure. [09:07:51] nice and short and clean [09:08:06] and dont need to write the messages 1000X [09:08:18] but thats it for classes [09:08:25] Anything for button? [09:08:29] yes [09:08:40] https://github.com/jquery/jquery-ui/pull/1415/files#r23699949 [09:09:34] Why isn't this just iterating over the items option? [09:10:21] because its not selecting the actual widgets [09:10:29] its selecting the buttons for those widgets [09:13:00] Have you looked at how buttonset handles this? [09:13:18] Because I don't think there's any other correct way to do this. [09:13:19] button set does not need to worry about what widget something is [09:13:27] That doesn't matter. [09:13:31] That's just an extension of what it's doing. [09:14:08] Why does it matter what widget the child is? [09:14:18] need to call a method on it [09:14:42] You know that at the time of construction. [09:14:57] yes which is saved in the data of the button [09:14:59] https://github.com/jquery/jquery-ui/blob/master/ui/button.js#L388-L391 [09:15:35] Inside controlgroup when you're constructing, you already know the widget type as you iterate over the items option. [09:15:35] scott_gonzalez: i dont see how that helps? [09:15:43] yes [09:15:47] You can very easily store the instances in an object keyed off the type. [09:15:51] i do [09:15:59] So why do you need to query the DOM? [09:16:09] im finding the visible buttons [09:16:21] buttons.filter( ":visible" ) [09:16:22] because i need to call option on the first and last [09:16:32] right [09:17:19] So why do you need to query the DOM? [09:17:31] L157 should just be using the existing data. [09:17:32] because they could have added removed buttons [09:17:34] this is in refresh [09:17:54] so i need to refind any buttons [09:18:49] You should be able to calculate that during the construction. [09:19:01] what do you mean? [09:19:25] oh you mean do it in _callChildMethod()? [09:19:48] yes [09:19:54] gotcha ok that makes sense [09:20:11] i can just ass i add the data to them push them to a collection [09:20:22] ok that solves that [09:20:35] ass/as [09:20:37] lol [09:20:53] ok thats all i got then [09:21:39] oh still does not answer though [09:21:44] if we should allow non children [09:22:00] I still have rebasing the datepicker branch on my todo list. I'll be doing that this week. [09:22:14] I tried last week, but there was an issue because simulate was moved in master. [09:22:27] And since we have a commit that does a complete rewrite, it gets lost. [09:22:52] So I just need to do some manual tracking of when things change in the main datepicker files in master that should still be applied. [09:23:15] Does anyone have anything else to discuss about datepicker? [09:23:39] Is the plan for 1.12 having Globalize 1.x ready? [09:23:55] and it using it [09:24:51] No, that's for 1.13. [09:25:00] Unless we're going to make the spinner API changes now. [09:25:14] But that's currently planned for 1.13, along with datepicker. [09:25:26] ok [09:26:10] We don't have enough progress on Globalize 1.0 anyway [09:26:16] While 1.12 is pretty close, I think [09:26:31] Some more TR fixes and the theme update should be done [09:26:40] Which only leaves classes and button [09:26:46] Yup, just need classes and button, et al. [09:27:13] 1.13 should be fairly quick too. [09:27:14] Getting there... [09:27:19] In terms of a major release. [09:27:25] Since we've made a lot of progress on it already. [09:27:38] Big things on Globalize are parsing currency and finish test automation. [09:27:51] Still need to handle CSS dependencies in download builder [09:28:06] That might end up the biggest blocked [09:28:11] rxaviers: any idea how long that might take? [09:28:15] *biggest blocker [09:29:36] currency parsing about a week. I have no idea of testing automation. [09:30:51] rxaviers: I meant the effort for CSS dependencies [09:31:22] Since that's a blocker for 1.12 [09:32:17] Mm hard to tell. But, it's my next item after landing TR new demos/ [09:32:45] okay, would be good to get an estimate once you've looked into it [09:33:33] sure, I will let you know [09:34:32] scott_gonzalez: what's that about resizable? [09:35:34] So we have `overflow: hidden` on dialogs. [09:35:45] A while ago, tj_vantoll and I decided it was safe to remove that. [09:36:04] Which makes things like autocomplete and datepicker work properly, since they're able to flow out of the dialog box. [09:36:20] But then we got a bug report that if you drag a dialog to the right edge of the window, you get a scrollbar. [09:36:31] Because the resize handles stick out past the edge of the dialog. [09:36:41] This is how resizable has always worked. [09:36:58] The handles are positioned partly inside and partly outside, providing a larger hit target. [09:37:10] So we have two options: [09:37:39] 1) Change resizable to not do that, and just make the handles smaller by default. [09:37:50] 2) Change dialog specifically to change the resize handles. [09:38:25] scott_gonzalez: im not saying we should do this but could you not also add ANOTHER wrapper to dialog [09:38:32] and have the handle be fully inside that [09:38:36] and set overflow on that [09:39:00] Only if we want to make dialog even more complicated by having multiple alsoResize elements. [09:39:21] You'd be resizing an inner wrapper which would need to resize the outer wrapper and the content div at the same time. [09:39:23] like i said i didnt say we should only that it would solve both problems [09:39:44] I had thought about that, but the simultaneous resizing really turned me off to that. [09:40:25] or could we some how make dialog stop xpx shy of right edge [09:40:25] Especially since for a dialog-specific solution, just changing the handles is much nicer and accomplishes the same thing. [09:40:37] No, containment isn't a dialog concern. [09:40:42] It's a draggable concern. [09:40:58] true [09:41:22] yeah i guess changing the handle size is the simpliest option [09:41:28] and a smaller handle is not horrible [09:42:10] How much smaller does it have to be to avoid the problem? Do we know? [09:43:38] https://github.com/jquery/jquery-ui/pull/1092/files#diff-2 [09:44:19] So 3px for the skinnier side handles. [09:44:29] And 5px for the bigger se handle. [09:44:52] They have to stay small enough to not occlude content/scrollbars. [09:45:11] And of course users can change the sizes and locations if they want with a few lines of CSS. [09:45:21] But we definitely want the defaults to be usable. [09:46:29] Seems a bit tough to grab (assuming I put this in correctly): http://jsfiddle.net/tj_vantoll/evs4dcpk/ [09:48:26] Also looks like there are some icon image paths broke in http://code.jquery.com/ui/jquery-ui-git.css per the theme update. [09:48:36] Well, that should actually be the same as what we have today, right? [09:48:47] It's currently 12px, but 5px is hidden outside. [09:49:08] So 7px @ 0 should be exactly the same as 12px @ -5px with overflow: hidden. [09:49:33] So that's one thing to consider. [09:49:46] We're not making the resize handlers any smaller than they are today for dialogs. [09:51:36] So the question is should we change resizable or just dialog. [09:51:49] Dialog's resize handles won't actually get smaller hit areas. [09:52:19] But the CSS will make them technically smaller because we'll be repositioning them to not flow outside the dialog. [09:53:31] So http://jsfiddle.net/tj_vantoll/evs4dcpk/1/ [09:53:48] That's 15x15 but entirely within the dialog. [09:54:06] Yeah, but that will kill the scrollbar. [09:54:43] Sorry I think I'm not following. How far does it have to go in to avoid the scrollbar? [09:54:57] Your first fiddle was correct. [09:55:06] It's the exact same positioning as what we have today. [09:55:35] Just smaller dimensions [09:55:35] Right now we have 12px wide, with 7px inside and 5px outside. [09:55:53] The 5px outside is ignored right now because we have `overflow: hidden`. [09:55:59] but the 5 outside is hidden by overflow right? [09:56:08] 7x7 feels too small to me [09:56:11] so its already 7x7 in practice? [09:56:14] yes [09:56:18] It's already 7x7 today. [09:56:20] And has been for years. [09:56:30] Effective size [09:56:36] I see [09:56:36] so nothing changes for users [09:56:42] Actual size is 12px, but 5px are unusable. [09:56:43] other then we fix the scroll bar issue [09:56:43] right [09:56:52] The scrollbar issue is already fixed. [09:57:00] so this seems like the right thing to do with out a doubt to me then [09:57:01] Oh, right, the scrollbar on the window. [09:57:11] I thought you meant the handle covering the scrollbar in the dialog. [09:57:14] yes on the window [09:58:27] because to users nothing changes so unless there is an open issue about the handle already being to small? [09:58:31] So, it sounds like we probably want to keep resizable as is and only change dialog's CSS. [09:58:42] but that would still really be a different issue [09:58:52] scott_gonzalez: thats what i would do [09:59:06] Right, and the opposite issue has come up before years ago. [09:59:09] Remove overflow: hidden; from .ui-dialog and change the positioning of the handles to move them inside the dialog and make them 7x7. [10:00:08] https://github.com/jquery/jquery-ui/commit/1ed853f7bb9f58af09e55e207534ecb10bcbe286 [10:00:33] Wow, that bug took way too long to fix. [10:00:35] http://bugs.jqueryui.com/ticket/4575 [10:00:42] tj_vantoll: correct [10:00:49] We'll also need to change the other handles too. [10:00:54] Yep [10:00:56] By default we apply all the handles. [10:00:58] For http://bugs.jqueryui.com/ticket/10543 presumably? [10:01:14] Yeah, this would fix that ticket. [10:01:24] I can put a PR together. [10:01:26] I didn't even look to see if there was a ticket about that. [10:01:29] Ok, thanks. [10:01:46] No problem. I feel like I haven't done anything useful in a while. [10:01:50] agcolom: we doin' this thing? [10:01:56] so seems like this is pretty straightforward then [10:02:04] danheberden: yes we do :) [10:02:11] i think thats are hint to wrap up lol [10:02:18] ui meeting is not finished... [10:02:30] That was the last item on the agenda. [10:02:36] Thanks everyone. See you back in -dev. [10:02:44] thanks scott! [10:02:46] agcolom: kswedberg: danheberden: AurelioDeRosa: RWitbeck: gnarf: sfrisk: meeting time! [10:02:55] hello [10:03:01] Hello! [10:03:02] I forgot people? (if so, sorry) [10:03:03] agenda https://docs.google.com/document/d/10BtIFF5R_djDCAtwJQiIxy3oOxdQeyrogWFoSvybFHA/edit [10:03:10] Me! lol [10:03:22] oh [10:03:24] sorry man [10:03:28] :-D [10:03:39] RWhitbeck: ^ [10:03:58] hello! [10:04:10] Hello! [10:04:18] Hi all! much to discuss today [10:04:46] First item is regarding the team leadership. I've been the team lead for the past 3 months but the board would like the team lead to be more involved with the day to day work. Anne is a really great communicator and would be awesome at getting things done, so I support the proposal for her to lead the team. [10:05:07] If anyone objects, let's address those - otherwise we can put a star on this and move on [10:05:24] I think Anne is a good choice. [10:05:29] +1 [10:05:30] LGTM :-) [10:05:32] +1 [10:05:43] those are terribly formed objections! lol :p [10:05:43] +1 [10:05:46] ok, boom done [10:05:54] Thank you :-) [10:06:07] Oh hi ... you rang? [10:06:18] How we can disagree? :) [10:07:04] I’d say [10:07:14] Oops that was for another channel :) [10:07:26] ok, so next item: Learn site [10:07:49] things we didn't get a chance to discuss last time [10:07:51] proposed: in addition to code snippets, we should have the full example in a jsbin to enable users to manipulate the code and enable us to easily update it. [10:08:04] (where possible) [10:08:09] that’s going to be terrible to maintain :-) [10:08:20] but useful [10:08:25] for sure [10:08:29] Instead of jsbins how about we push the functionality of the site to run the demo's inline? [10:08:30] arthurvr: not really jsbin is going to have an api for auto generating and pushing bins [10:09:12] this has actually been in the works to use for ui demos and maybe api for a while [10:09:14] my thinking behind it was for example when you have an article or tutorial with screenshots... [10:09:20] but stalled around the holidays [10:09:34] k. Thanks for the info [10:09:43] and sometimes the UI changes a lot between releases... [10:09:56] and we do not have the code for the demo... [10:10:05] I emailed Remy the creator of jsbin and Kris this morning to get things rolling on that again [10:10:40] yes, and that would work nicely with the UI proposal also for GSOC [10:10:48] arschmitz: just to make sure, we can control the source of these examples from our content, yes? [10:10:58] danheberden: yes thats the idea [10:11:03] awesome [10:11:15] to be able to just fork an example [10:11:16] we would keep them in our repos and then the deploy script would push any changes to jsbin [10:11:19] that would be so baller [10:11:25] nice [10:11:30] Awesome! [10:11:34] sounds great! [10:11:47] so thats in the works no idea on timeline right now [10:12:24] sounds really good [10:13:12] this is more or less how the ui ones already work [10:13:20] they get parsed out of the actual ui repo [10:13:25] and put into jqueryui.com [10:13:36] so now they would just push to jsbin at the same time [10:13:53] that would be really awesome for Chassis in the future too [10:14:02] yes [10:14:08] oh and we will also get custom subdomains [10:14:17] like jquerymobile.jsbin.com [10:14:18] etc [10:14:22] Nice! [10:14:46] so we can have like jquery-learn.jsbin.com or something [10:15:10] kind of like http://emberjs.jsbin.com/?html,css,js,output ? [10:15:16] exactly like that [10:15:19] sweet [10:15:27] so we can customize the look [10:15:33] and also make the editor use our style guide [10:15:37] so tabs vs spaces [10:16:28] not style guide but suggest editor config [10:16:33] sweet, what's next? 'list of articles, etc' ? [10:16:45] ”proposed: Create a list of articles/tutorials/video that would be nice to have” [10:16:59] wasn't there an issue for this? [10:17:08] only for the videos [10:17:32] https://github.com/jquery/learn.jquery.com/issues/561 [10:18:01] Do we have the resource to manage this sections too? I mean in addition to all the other sections... [10:18:03] videos are awesome but tend to get out dated more quickly then articles often i feel like so it would require more active curation [10:18:05] would it make sense to make separate issues for each thing? [10:18:23] Videos, articles, and guides become outdated fast [10:18:41] it sounds like a plan to maintain said section would be part of this initial investigate's acceptance criteria as well [10:18:49] *investigation's [10:18:52] for videos would it maybe make more sense to point to a youtube channel rather then add it all to learn? [10:19:10] I like the idea of a YouTube channel [10:19:12] and just list one ( or several ) channels on a page on learn [10:19:13] that was discussed for the jquery14.com - just stuffing them all on youtube [10:19:14] yes, I would think so [10:19:43] ya - but content (even videos) should be linked to specifc articles IMHO [10:19:44] and then anne gets all the ad revenue [10:19:54] :-) [10:19:56] and Internet Points™ [10:19:58] haha, nice [10:20:05] seems much easier to deal with / maintain and people are much much less likely to get grouchy over dated videos that way [10:20:06] (you can cash those in for cool cat pics) [10:20:19] except: youtube comments [10:20:41] hey sorry, catching up [10:20:47] youtube videos basicly never go away though [10:20:54] so people expect them to become dated [10:21:00] unlike a curated website [10:21:06] also they actually have a date [10:21:19] yes, I was going to say exactly that [10:22:31] So do we want to have a list of nice to have articles or do we just open one issue if we would like an article that isn't there? [10:22:44] I think that’s the best way of handling this [10:22:46] (I'm thinking option 2 would make more sense?) [10:23:12] Then we can keep discussions focussed, so +1 [10:23:14] One article at a time might increase a lot the number of issues to catch up [10:23:24] arschmitz / danheberden / arthurvr : I wrote a "create a jsbin on the fly" script for my slide deck last jqcon - it's pretty easy: http://gnarf.net/scoping-out-scope and view sources [10:23:36] yes but can be allocated to someone [10:24:03] gnarf: is that using their api? [10:24:21] i didnt think it was ready yet / pro only last i checked? [10:24:22] yes - I think we’re going to end up opening a bunch of issues while forgetting to work on them. [10:24:34] Maybe we should have a limit for ourselfs [10:24:39] would a mix of audit/evaluate-needs of specific areas be useful? [10:25:07] yes, probably [10:25:07] arschmitz: search source for jsbinifyCodeBlock [10:25:14] like someone creates a list for articles that is three parts. a) must have b) nice to have c) won't have [10:25:19] it just does a post to jsbin and creates one on the fly with the content [10:26:01] danheberden: that could work. [10:26:11] what would go in won't have? [10:26:32] mostly things that are there that should go away, or calling out specifically things found that are like "Awww hell no that'd be a waste of time" [10:26:40] (too easy or not relevant, i.e. other resource elsewhere?) [10:26:46] i'm sprinkling my day-job-manager bullshit in here [10:26:53] so take it all with a grain of salt [10:27:43] so we could add that to the doc we're using for analysis... [10:29:07] would that be ok? [10:29:38] what doc do you mean? (sorry if I’m missing something) [10:29:57] https://docs.google.com/spreadsheets/d/1H6xhKoSBtoK9Nsc7uqBcVQULqflc7xWZbtsTO7p1fqA/edit#gid=0 [10:30:08] oh just that one. Perfectly fine [10:30:57] i have a meeting i have to run to; call me out on anything in the notes you want me to address [10:31:10] k. thanks dan! [10:31:38] Thanks danheberden [10:32:24] agcolom: do we have an issue open to track the work/link to that spreadsheet? [10:33:02] gnarf: we do, but it's in the Foundation issue I think [10:33:07] Is it something we want to keep internal, or rather have it being public? [10:33:15] so would make sense to open one. Thanks for pointing out [10:33:28] I feel its a public/team issue [10:33:33] no real reason to hide it IMO [10:33:49] unless someone has one [10:34:03] also then I can link people to it if they offer to read a few articles :) [10:34:09] I'm happy being open about it. [10:34:23] yes, that would be great! [10:34:42] I have some n00bs wanting to give us some feedback too. Open issue might be handy [10:35:04] we should have an email address in the matrix for reviewers then [10:35:09] maybe? ^ [10:36:10] Currently I just asked them to send all feedback to my personal email. [10:36:18] we would want some way to get ahold of them i think [10:36:34] agcolom: make it "open for pubilc to comments" [10:36:47] ya seems like a good idea [10:36:49] ok, so I'll add a column for that [10:36:50] so that we have to add the info given the comment in the goog doc [10:36:54] gnarf: great idea. [10:36:56] team can just edit [10:37:36] yes [10:37:49] ok to move on? [10:37:58] yep [10:38:01] Actions from last meeting: [10:38:09] scott_gonzalez: to work on automating the CLA check, which will manage the label [10:38:30] I've not spoke to Scott about this... s [10:38:49] so I'll say ongoing [10:38:50] ? [10:38:59] yup [10:39:01] Can we ping him now to have an update? [10:39:13] we haven't moved much on it [10:39:17] the code is pretty much ready [10:39:20] It's on my list. I did not plan to get to it by now. [10:39:21] that's why I used his nick [10:39:24] need to setup the infra side [10:39:57] It is item #3 on my todo list though. [10:40:02] yes, not a short term action. I'll just keep it in the agenda so we don't lose it [10:40:14] scott_gonzalez: when it gets closer to the top remind me and I'll be ready to make the infra part ready [10:40:32] gnarf: Will do. [10:41:31] Aurelio to see how we can get more help from the community [10:41:31] https://docs.google.com/document/d/1qeiwEtiIitFt1X8Iu1Cu2X0GgwM-MSb4FOOl50oerPY/edit [10:41:37] next item: ^ [10:41:52] Thanks AurelioDeRosa for the doc. [10:42:09] :) [10:42:11] would be good if everyone could take a look and add comemnts/edits [10:42:22] cc: RWhitbeck too [10:42:25] AurelioDeRosa: i like the direction this document is going - do you know if ajpiano / DaveMethvin have looked at it yet? I like to think either of them have a great sarcasm/humor we could maybe use to lighten it up and make it sound more fun :) [10:42:56] gnarf: yes, that's what I was thinking also... [10:43:20] AurelioDeRosa: who did you share with... [10:43:25] I don't think DaveMethvin has reviewed the document but I may be wrong [10:43:51] is this gonna b e a blog post [10:43:51] The same people of one document you shared with me: you, arthur and the group [10:44:16] it's def a good start [10:44:28] ajpiano: blog would be nice i think [10:44:45] +1 [10:44:49] agreed seems like this should be a blog [10:44:56] and/or tweet :) [10:44:59] yes, the original idea was a blog post that can be shared via Twitter [10:45:15] kinda related: https://github.com/jquery/learn.jquery.com/issues/569 [10:45:16] gnarf: dont we tweet all our blog posts? [10:45:20] (yes) [10:45:27] so action on me to ask Dave to take a look? [10:45:38] but the 140 char version of a blog post title is like ajpiano specailty :) [10:45:55] I think so, agcolom [10:46:21] About that issue I linked to, might be worth it to have the long-term plans explained in there too. [10:46:48] DaveMethvin: if you are around, could you please take a look at Aurelio's doc? (we're looking at creating a blog post to get contributors' help with learn and other sites) [10:47:00] yep, looking now [10:47:00] DaveMethvin: You have 1 new message, use `read when you wish to read it. [10:47:12] sorry... I keep disconnecting! [10:47:13] Thanks Dave [10:48:23]