[08:32:37] QUnit meeting! Ping JamesMGreene leobalter Krinkle|detached (anyone else?) [08:33:21] hey [08:33:35] Also ping sfrisk_ since we might talk about CSS testing frameworks, regarding https://github.com/jquery/css-chassis/issues/25 [08:34:11] Where's Gibson? [08:34:23] Not here! [08:34:41] Looks like we haven't had a meeting in quite some time [08:34:45] https://docs.google.com/document/d/13FbWhiFQ9gWQvB1Tm4QM_OC4me-ha2ujDWH5sdF7ueo/edit [08:35:31] and we have some minor regressions to fix, found after releasing 1.16 [08:35:58] let's put the pre-2.0 milestone on those [08:36:04] hi! [08:36:06] or we create one for 1.16.1? [08:36:07] hey, just got in [08:36:59] hi sfrisk gibson042. If you have any concerns regarding QUnit, let us know. [08:37:11] Okay, sounds good [08:37:44] leobalter: I created a 1.16.1 milestone, lets put regressions in there [08:37:48] ok [08:38:05] gibson042: what do you think about https://github.com/jquery/qunit/pull/714#issuecomment-67344384 ? [08:38:28] I like it [08:38:31] updating the PR now [08:38:39] how so? [08:38:44] oh, hang on [08:38:46] wrong comment [08:39:57] I'm going to end up with something similar to that (e.g., `conditionalTest( name, condition, fn )`) [08:40:10] but it seems common enough and valuable enough to have a home in QUnit proper [08:40:40] and fits with concepts on the original discussion around skipping from JamesMGreene [08:41:30] Why not abstract the condition? [08:43:14] Well, we can continue that discussion on the PR [08:43:25] as in `testInIE9`? we'll probably have something like a dozen variable conditions, which IMO justifies full generalization [08:43:26] ok [08:43:41] leobalter gibson042: Does any of you happen to have experience with (unit) testing css or sass? Regarding https://github.com/jquery/css-chassis/issues/25 [08:44:44] gibson042: if all of those are only used once I can see why you want just one abstract method. [08:46:02] jzaefferer: I opened that issue just because when i was doing some reading on sass on the train those were a couple things i found people suggested [08:46:18] jzaefferer: it may not be something needed for chassis i just figured it was worth looking into [08:47:08] What arschmitz said [08:48:25] I have no direct experience, but am agreeable to the concept [08:48:40] I think ill ping dam ( Kristofer Joseph ) on it if no one has any experience since he did a lot of work around testing for topcoat maybe he has looked into this [08:49:05] That sounds good [08:50:03] yeah, would be nice to get some input from someone who looked into that before [08:50:47] Definitely. [08:51:10] jzaefferer: a new unit testing book was released http://blog.jayfields.com/2014/12/working-effectively-with-unit-tests.html?spref=tw&m=1 [08:53:10] leobalter: thanks, I'll take a look [08:53:27] I think thats all for today. I hope to see JamesMGreene around sometime soon, to continue work on js-reporters [09:00:24] arschmitz: jzaefferer fnagel gnarf jperrault kborchers mikesherov rxaviers [09:00:32] hey [09:00:32] Hi [09:00:32] o/ [09:00:37] hello [09:00:49] hey [09:01:54] dekajp sent a PR for one of the regressions: https://github.com/jquery/jquery-ui/pull/1398 [09:02:22] I pointed him to spinner's precision logic to guide him. [09:02:27] But I haven't had a chance to look at the PR yet. [09:03:32] Looks like we can definitely optimize this a bit, but I'll look into it detail later. [09:03:49] What's up with AMD in tests/demos? [09:04:49] I chatted with jzaefferer this week and the next step is to revert testsuite helpers AMDifcation. [09:05:04] we've* [09:05:29] hi [09:05:37] no resolutions so far [09:06:23] Hey mikesherov. [09:06:40] mikesherov, Have you had a chance to look at http://bugs.jqueryui.com/ticket/10590? [09:11:15] meanwhile, arschmitz, how's the classes update going? [09:11:24] Heh, I was just typing that :-P [09:11:31] scott_gonzalez: not yet [09:11:37] will do this week [09:11:39] I hate grid [09:11:41] Going keep finding more stuff to do [09:11:44] it makes me sad [09:12:02] like noticed all previous prs i had based all my work off included interactions [09:12:20] so started updating those this morning [09:12:34] oh but so every one knows [09:12:48] we decided on _addClass( elements, keys, extra ) [09:13:02] but we will do autodestroy for classes [09:13:28] and all null nested option values will no longer be defined in the widget [09:13:47] and classes is switching from "" to null for anything with out a value [09:14:01] so this means most of the classes object definitions go away [09:14:16] and we will add _toggleClass [09:15:01] which will just be _toggleClass( elements, keys, extra, bool ) [09:15:08] and bool will be 100% REQUIRED [09:16:11] jzaefferer: scott_gonzalez: i think that covers everything we decided right? [09:16:24] I think so. [09:16:48] and if you care about LOC this is a big win in terms of classes [09:17:24] between the definitions and destory we drop a LOT of lines from old implementation [09:17:39] mikesherov's effects rewrite landed :-) [09:17:46] WOO! [09:17:56] So that fixed a bunch of bugs. [09:18:59] And just as exciting, Google finally transferred the PointerEvents polyfill :-) [09:19:00] https://github.com/jquery/PointerEvents [09:19:08] We'll be announcing that today on the jQuery blog. [09:19:46] OH MY GOD YES!!! [09:20:20] hooray [09:20:29] just in time for the PR announcement? [09:20:32] for pointer events? [09:21:33] Yeah, so in related news PointerEvents became a Proposed Recommendation at the W3C yesterday. [09:21:56] YAY! [09:22:05] its a good week for pointer events [09:22:12] which is good one has been needed! [09:22:19] IE is fully passing the W3C tests. [09:22:43] And so is the Firefox implementation, but that's not available in all of their builds yet. [09:23:24] So we'll be able to start making progress on the interaction rewrite with Pointer Events again. [09:23:53] i cant wait to pull into mobile [09:23:58] SO MANY THINGS FIXED [09:25:09] Anyone have anything else to discuss today? [09:27:25] Thanks everyone. See you back in -dev.