[09:02:46] i am on a call [09:03:57] I have completely lost the past week, and it seems to be the _worst_ week to say that about [09:05:24] gibson0421: what do you mean? [09:06:50] I spent zero time on jQuery, and judging by email subjects it would have been very beneficial to have done so [09:07:21] we love you gibson0421, come back! [09:07:57] I sure want to :) [09:08:06] if you could get the deferred pr done that would be awesome, i think that's the main item in your inbox [09:08:46] there are a couple of Sizzle-related topics [09:09:39] gibson0421: any take on https://github.com/jquery/sizzle/issues/290? [09:09:44] here [09:09:51] hi :) [09:10:27] anyone taking minutes? [09:10:37] i am not ... will have to bail in a second [09:10:54] k [09:11:38] I'm doing it [09:11:57] cool [09:12:15] so, https://github.com/jquery/sizzle/issues/290 [09:12:34] Apple is apparently not interested in fixing it in iOS8 [09:12:35] m_gol: I think we're driven to a new buggyQSA test [09:12:45] yea, sounds like it [09:13:04] I would've never suspected such a simple selector to not work [09:13:11] in a new browser [09:13:12] gibson0421: you or me? [09:14:06] do you know what _exactly_ broke? [09:14:19] the webkit ticket wasn't exactly clear to me at first glance [09:14:21] I'd have to investigate the cases. Do you? [09:14:36] "#id + p" works, "p#id + p" breaks [09:15:01] sure, but we need to all cases [09:15:07] yeah, sure [09:15:28] i.e., what about `tag#id ~ …` or `tag#id …`? [09:15:55] fwiw, Safari 8 breaks in the same way, probably easier to test on desktop [09:16:45] or `[attr]#id`, or ... [09:16:46] gibson0421: tag#id ~ breaks as well [09:17:06] if it breaks in enough cases, we'd probably just set support.qsa to false [09:17:13] which sucks [09:17:29] '[style]#a ~ div' breaks [09:17:53] tag[attr] div? [09:18:05] maybe tied to compound with ID? [09:18:10] it seems anything#id ~ anything breaks [09:18:18] anyway, we could figure this out later [09:18:30] ok, not anything [09:18:32] right [09:20:55] what else we got? [09:21:22] got to go .. timmywil can you close the channel? [09:21:27] sure [09:21:35] thanks guys [09:21:42] gibson0421: how's your .done proposal? [09:21:45] browser suppoort ;) [09:23:04] actually, I have a half-finished response to jaubourg's PR that raises questions for which this would be the proper venue [09:23:29] re: compatibility with older jQueries and Promises/A+ and ECMAScript [09:24:00] we need to decide exactly what we're changing, and it will probably come with deprecations [09:24:19] but since it's only half-finished, I don't think much can happen on it yet [09:24:42] ok [09:26:17] So, now that we're on github issues, I have this dream that we get to a really small number of issues. There's probably still some triage we can do and there are some small ones to go through and knock out. Have a look at the list to see if you can grab any. [09:27:36] Also, I think adding Shadow DOM support to Sizzle should be pretty trivial, but it might be a lot more complicated in core. We have an issue focused on .offset(), but I'm sure there are other areas we could look at. [09:28:16] Feel free to open another issue if you think of an area that needs changes to work with Shadow roots. [09:28:17] timmywil: did you check if it already works? [09:28:30] yea, it's another nodeType I believe [09:28:39] I thought they were DocumentFragment nodes [09:28:50] ah, right, but the supported methods differ [09:29:23] like it supports qsa, but not gByID or something [09:29:26] in that Shadow DOM supports more element methods, or fewer? [09:30:00] https://github.com/jquery/sizzle/commit/911362e4570591d84e4358971414e724ef3bfa52 might have been all we need [09:30:07] It's been a while. Someone opened an issue a while ago. [09:30:32] Maybe, I just ported an issue from bugs.jquery.com [09:30:36] ok [09:31:17] would be great if we don't need more changes [09:31:24] but we could use a shadow root test [09:31:32] took the words right out of my fingers [09:32:04] anyone have another issue to bring up? [09:32:07] https://github.com/jquery/jquery/pull/1837 [09:32:21] any additional feedback? do you want to look at it more before landing? [09:33:12] looks good to me as long as tests pass [09:33:34] I still don't understand why this line: https://github.com/jquery/jquery/pull/1837/files#diff-6d4bb79610683d9749d2cbb62e708d88R19 is necessary for tests to not break... [09:33:37] need to investigate more [09:34:05] apart from that I can land it unless someone wants to have another look [09:34:19] tests pass at least on IE8, Fx, Chrome & Android 2.3 [09:34:36] oh, is it that doc ready line? [09:34:48] yes [09:35:07] is it the last one in compat internally? [09:35:58] no :) [09:36:10] heh, then I have no guesses [09:36:12] ah, a moment, wrong branch [09:36:14] lemme check [09:36:15] again [09:36:31] yes, that's the last one [09:36:50] so, we might need at least one to ensure doc ready gets run [09:36:52] (at least the last one matching /jQuery\(\s*function/ [09:37:02] might be different in master [09:37:05] yeah, but it's not needed for master [09:37:53] yea, look at bottom of ready.js in master [09:38:02] might need the same in compat [09:38:06] ah, right [09:38:23] thank you :) [09:38:32] np ;) [09:38:56] aight, if that's all, I'll close the channel [09:38:58] that reminds me [09:39:06] that I can remove the doScroll(left) hack [09:39:09] as well [09:39:15] oh yea! good call [09:39:24] I wonder how many of those I've missed... [09:39:37] we can always do more incrementally too [09:39:40] sure [09:39:49] thanks all! [09:39:52] thx