[11:01:47] gabriel_schulhof: agcolom: cgack: gseguin: Meeting time [11:01:55] hey :-) [11:02:07] Good evening! [11:02:14] ... for some. [11:02:20] howdy! [11:02:47] Sorry guys I can't make the meeting today [11:02:59] gseguin: Hi! Bye! [11:03:30] hi [11:03:44] hi ldeluca2 [11:03:52] ldeluca2: Hey! [11:04:21] agenda: https://docs.google.com/spreadsheet/ccc?key=0AskujzE4Ig0QdG5nSmZiSUhjYm4ya29CdjhLZmJwSWc&usp=drive_web#gid=47 [11:06:56] ok lets start with 1.4.5 [11:07:03] hi all [11:07:03] we need to recheck these issues [11:07:18] apple actually fixed safari in a patch [11:07:19] sorry for being late... had connection troubles :( [11:07:30] at least one of the issues we had was fixed [11:07:52] im hoping the selectmenu one might have been as well in which case we can go back to not doing a 1.4.5 [11:09:15] arschmitz: Wait a sec ... the delaying-the-blur issue was fixed in the browser? [11:09:27] gabriel_schulhof: i dont know i said we need to check [11:09:45] there was a rendering issue that was pretty major they fixed though [11:09:47] arschmitz: BS has iOS 8 ... [11:10:06] gabriel_schulhof: i will check with my phone [11:10:28] a full on browser crash is major enough im hoping they fixed it [11:10:28] arschmitz: Oh, OK. You have iOS8 ... cool! [11:10:37] Indeed. [11:10:46] You didn't need jQM for the crash to happen. [11:10:53] nope [11:11:16] so fingers crossed on that being fixed [11:12:24] for 1.5 not too much real progress this week i dont think im working on a bunch of updates in ui that need to be pull before anything can be landed [11:12:48] those should be done in the next week [11:13:18] Well, I've certainly made progress. [11:13:24] ... on my classes PRs. [11:13:30] yeah i saw some commits [11:13:35] i have not looked yet though [11:13:48] I've gotten them all to update the classes values in response to style option changes. [11:14:00] 6 widgets. [11:14:17] 3 don't need that. [11:14:18] by just proxying to classes with set options or? [11:14:53] Basically, I've kept the code for actually adding the classes to the element, but I'm using a common module for parsing/modifying the value of the class key. [11:15:12] gabriel_schulhof: so entry for classes in notes was PR's need updating. Now can be PRs have been updated? [11:15:38] agcolom: Nono. I still need to change the default empty value for the class keys from null to "". [11:15:44] ok [11:15:48] agcolom: ... but that's a fairly mechanical change. [11:16:03] ok, should we change the status in notes for that? [11:16:14] i.e. progress being made [11:16:44] arschmitz: So, when we hack out the style options, we can simply get rid of the backcompat module, the existing _setOptions code, and all the calls to the backcompat module. [11:17:07] gabriel_schulhof: ok [11:17:14] arschmitz: The good thing about using the module is that if you remove it, you'll get undefined reference errors in all the places where you need to remove code. [11:18:22] gabriel_schulhof: sounds good [11:18:25] arschmitz: Oh, so if you see the same code in all the PRs, that's not separate commits. That's the same commit on all the branches. [11:19:05] Anyway, that's it for my work on classes. [11:19:06] gabriel_schulhof: that should probably be a seperate pr really then [11:19:28] arschmitz: I guess we can merge it into ui-1-12 and then rebase them on top. [11:19:48] ... but I'd leave it for now, awaiting the test fixes. [11:19:48] gabriel_schulhof: thats what i was thinking [11:20:05] I could really use a passing test suite. [11:20:48] gabriel_schulhof: what failures specificly [11:21:10] Well, my ui-1-12-test-fixes PR fixes everything except checkboxradio. [11:21:14] So that's all that's left. [11:21:32] ... and I know you're busy, so don't worry about it. There's plenty of other stuff I can do in the meantime. [11:21:33] gabriel_schulhof: ok ill review that so we can get it landed later today [11:21:52] arschmitz: Yeah, that should make most of the tests green. [11:21:53] the checkboxradio one will have to wait for the rest of the ui updates [11:22:00] Yeah. No worries. [11:22:23] A review of that test fixes PR would actually cover most of the classes options-related stuff. [11:22:41] gabriel_schulhof: ok ill look at it this afternoon [11:22:47] Awesome! Thanks! [11:23:48] hopefully in the next week all the classes updates and the button checkboxradio and controlgroup updates will be done [11:24:19] That'll be a helluva landing. [11:24:45] lol [11:24:51] yeah im pretty busy right now lol [11:25:50] jasperdegroot: any progress on updating the css? [11:26:12] arschmitz: yeah, you can follow it here https://github.com/jquery/jquery-mobile/pull/7753 [11:26:30] button-css branch is also used for icon spans now [11:27:00] working on updating the button and icon demo pages [11:27:21] to see if it work as expected [11:27:33] execlent [11:27:50] then need to updated all widgets that use icons to generate a span instead of adding class to anchor element [11:27:56] listview, collapsible, etc. [11:27:57] that will be super helpfull when checking the other pr's [11:28:18] jasperdegroot: maybe gabriel_schulhof could help with that if you want? [11:28:33] yeah that would be great [11:28:48] Whew! [11:28:50] Sounds like fun! [11:29:05] Other fun things: Documenting the classes options in the API docs. [11:29:19] I'll update the PR comment to mention all specific widgets instead of "Update all widgets that use icons to generate spans instead of adding icon class to the anchor" [11:29:30] yup [11:29:37] jasperdegroot: ... and add a checklist [11:29:42] ... if not already there [11:29:47] gabriel_schulhof: there is a checklist [11:29:52] Great! [11:29:53] jasperdegroot: i wonder if you can nest checklists lol [11:29:59] You can. [11:30:03] but I didn't make a bullet for each widget, just one generic one [11:30:20] arschmitz: I was wondering the same :) [11:30:30] jasperdegroot: ping me if there's anything I can help out with [11:30:55] arschmitz: casper is happy with cdn.rawgit.com [11:31:22] cgack: the rewritten navbar widget also need to generate spans for icons [11:31:29] gabriel_schulhof: they explicitly say to use that for production which we essentially are [11:31:33] or does it depend on button widget for the buttons? [11:31:35] so thats good and its cached forever [11:31:45] so as long as we stick to tags all will be right [11:33:46] ok so jsbin links [11:34:14] Remy fixed linking bins for us a while back but there is a special way to handle this [11:34:34] simple quick way for now is to add .html it the bin version number [11:35:12] this can also be done by changeing the x-requested-with header in the ajaxSetup [11:35:45] i want to add the second one to our template [11:36:00] however im working on trying to get us some jsbin vanity urls [11:36:00] arschmitz: How about just adding a comment pointing out that people should be adding .html to external page links? [11:36:24] gabriel_schulhof: just adding that what can be 1 line snippit just makes it work [11:36:41] and makes it possible to reproduce issues with url parsing [11:36:49] OK. [11:37:11] Vanity urls will be nice if we can get them though [11:37:15] Aaah, yes, actually. Like the missing closing / [11:37:27] so we can update the template with out changing the url [11:37:42] and get something nice like jsbin.com/jquery-mobile/ [11:37:52] that would be nice [11:38:13] so im waiting to hopefully hear back about that before we update the template [11:39:08] https://www.youtube.com/watch?v=3M68wcB6L0s [11:40:02] ok website spider [11:40:10] we have had a spider on our demos for a while now [11:40:35] iv been putting more work into this since chicago and its now a grunt plugin [11:40:50] and we will be using it on all the jquery websites [11:41:17] its already found a LOT of broken links we had no idea about [11:42:31] like in the api all links to other sites in old versions so like in the 1.3 api [11:42:36] all links were broken [11:44:56] I hope the API links I added back for 1.5 are not broken :) [11:45:10] jasperdegroot: no this was links from the api not to it [11:45:22] ah ok, misunderstood [11:45:34] jasperdegroot: it was wordpress doing some url re-writing [11:46:12] :( [11:46:27] its fixed everywhere now [11:47:14] so dont be suprised to see a lot of link fix commits in the next few weeks on the content sites im not bothering with prs on any of the sites its too time consuming for simple fixes [11:47:33] ok [11:47:53] OK. [11:49:31] so far jquery.com, api.jqueryui.com, the ui demos, and the mobile demos are all green [11:49:59] Cordova [11:50:18] ldeluca2: has been helping out on all our old sad neglected cordova and phonegap issues [11:50:27] :) [11:50:31] :+1: [11:50:37] which is a huge help [11:50:49] we are pretty terrible and lazy about these issues [11:51:17] so this is really good since thats a big audience for us [11:51:24] happy to help out! Feel free to add my name to issues related to Cordova and I'll dive in. arschmitz has already done it for a few [11:51:43] awesome [11:51:43] one thing i think we should lookinto is something like grunt-cordova [11:52:20] maybe we could package the demos as a cordova app for easy testing on issues [11:53:06] arschmitz: good idea [11:53:07] Too bad you can't launch a cordova app on BS :/ [11:53:21] gabriel_schulhof: yeah [11:53:28] Not that BS is that great anymore ... it's dog slow. [11:53:36] gabriel_schulhof: I found genymotion is to be way easier to test for Cordova than BS [11:53:39] gabriel_schulhof: its always been slow [11:53:45] gabriel_schulhof: at least for android [11:54:40] ldeluca2: have not tried that will check it out [11:58:38] ok moving on [11:58:47] just one thing left [11:58:59] Welcome! Cory! [11:59:18] thanks! [11:59:23] Welcome! [11:59:34] cgack: Welcome! [11:59:59] \O/ [12:00:13] hopefully I don't break too much now that I have more access to the repos :) [12:00:27] lol [12:01:02] cgack: That's exactly how I felt when I joined :) [12:01:17] cgack: ... and I did slip up a few times. [12:01:36] cgack: Don't sweat it. It's git. It's not like you lose anything. [12:01:40] distributed source control FTW [12:01:42] cgack: we all break things [12:01:48] Yep. [12:02:16] you cant really break real stuff till you have cdn access [12:02:36] oops broke the internet... [12:02:44] haha [12:02:46] anyway does anyone have anything else? [12:03:17] I am good [12:03:28] Same here. [12:03:40] Anything from the community? [12:04:12] ok see everyone back on -dev