[09:00:15] arschmitz fnagel gnarf kborchers mikesherov rxaviers tj_vantoll\ [09:00:20] hi [09:00:21] hey [09:00:23] hey [09:00:25] howdy [09:01:20] So, let's start with the big news. [09:01:24] AMD landed in master. [09:01:36] \o/ [09:01:40] :) [09:01:58] :) [09:02:21] We still need to update our tests to load files through AMD to ensure test coverage. [09:03:01] I assume rxaviers will just continue from the work he already did in the PR. [09:03:27] correct. Do we want AMD tests on 1.11? [09:03:37] for* [09:03:40] yup [09:03:45] ok [09:04:26] Nothing else to discuss about AMD right now, correct? [09:04:57] nothing else occurs me [09:05:01] I started work on a tutorial on it for the learn site. [09:05:44] Great. We should publish that at the same time as 1.11. [09:06:11] Yeah, it'd be a good thing to link to from the release blog post / upgrade guide. I'll have it ready in time. [09:06:33] Sounds good. [09:06:51] arschmitz is working on checkboxradio. [09:07:04] Anything to discuss regarding that right now? [09:07:21] nothing to discuss its back to where it was with before and after [09:07:30] im fixing some things people had noticed with that [09:07:46] then ill do a [09:07:51] PR with the new branch [09:08:43] Great. Hopefully we can get a good review/discussion session in San Diego. [09:08:55] yeah that would be awesome [09:09:39] rxaviers has been working on the date module for Globalize. [09:10:40] https://github.com/jquery/globalize/pull/202#issuecomment-33504187 explains the current plan for dealing with timezones. [09:13:07] That's everything on the agenda. Is there anything else that someone would like to discuss? [09:13:42] I'd like to discuss http://bugs.jqueryui.com/ticket/9775 [09:14:52] I'm not sure that we should have any of this built into datepicker. [09:15:04] Does anyone have a good feel for how often weekend markings are actually used? [09:15:36] You can easily add the behavior this user is looking for with an extension point in the rewrite: https://github.com/jquery/jquery-ui/blob/datepicker/ui/jquery.ui.datepicker.js#L433 [09:15:56] I think their request is reasonable, but an edge case. [09:16:53] Should we close as "plugin" and explain how it will be handled in the rewrite? [09:17:47] does datepicker mark end of weekend now? It seems so, right? Using ui-datepicker-week-end class? [09:18:01] Yeah [09:18:07] I'm torn. It looks bad if we close it as "plugin"… when you can't actually build a plugin currently. [09:18:20] So just leave it open until the rewrite lands? [09:18:33] Do you want to remove it from datepicker, and make this as a plugable feature? [09:18:49] yeah [09:19:05] So remove all weekend handling altogether in the rewrite? [09:19:30] Is the rewrite doing anything for weekends right now? [09:19:34] nope [09:19:36] ok, got it.. I thought we were talking about making pluggable the code to make weekend dynamic. [09:21:14] But, I vote to not make this an option. But, part of the localization using globalize. [09:21:17] I haven't seen many datepickers where there's actually different styling or anything for weekends. [09:21:28] vote for* [09:21:48] Looks like usairways.com styles them. [09:21:49] I've used beforeShowDay: $.datepicker.noWeekends for a scheduling use case before. [09:22:30] tj_vantoll: me too [09:22:41] I say we add the current class names using the current implementation. [09:22:43] Sure, that seems easy to implement though. [09:22:49] But we make it extensible. [09:23:06] So this guy with his edge case can do what he needs to do. [09:23:07] If we're going to add them, we need to do it right. [09:23:21] Adding the classes is different than disabling the dates though. [09:23:31] This ticket is about adding the classes. [09:23:45] Specifically the concern is about adding classes to the headings. [09:24:43] The datepicker currently uses the firstDay option to drive the ui-datepicker-week-end class name exclusively. [09:25:03] If we're going to keep the classes, it should be based on CLDR. [09:25:22] And we have that information, correct rxaviers? [09:25:28] correct [09:25:50] It basically comes down to how popular we think it will be. [09:26:54] Is there an API in Globalize currently to access this information? [09:27:10] From the widget's perspective this should be simple. [09:27:34] Heh, http://www.flyfrontier.com/ has a script error for their datepicker. [09:27:47] If ( Globalize.isThisDayAWeekendDayInThisCultureOrWhatever) { [09:27:48] addClass( "ui-datepicker-week-end" ); [09:27:48] } [09:27:52] I'm checking all of the major airlines right now. [09:28:24] tj_vantoll, cldr.js has an API to access any CLDR info. Globalize exposes the cldr.js instance, so we can access any info using Globalize. If this it too hacky, we can proxy it via some API on Globalize. [09:29:02] lol [09:29:10] ok [09:32:42] I checked every airline on the first three pages of Google, plus kayak, hipmunk and AOL. Three sites styled the weekends. [09:33:00] So that's about 10%. [09:33:31] That's probably high enough to include, since it wouldn't be an option, it'd just be built-in and smart enough to use the locale data. [09:33:43] Yeah, I say we accept the ticket and document this on the Wiki. [09:34:38] +1 [09:34:42] ok [09:34:50] probably a good option would be a boolean whether or not to highlight weekends [09:35:12] letting localization handle the details [09:35:13] With the class names that's trivial to add on your own. [09:36:05] http://bugs.jqueryui.com/ticket/9775#comment:6 [09:36:36] Looks good. [09:36:39] +1 [09:37:33] Anyone have anything else to discuss? [09:38:51] Ok, see everyone back in -dev. [09:38:54] Thanks.