[09:02:54] DaveMethvin: It's open [09:03:02] thanks! [09:03:37] orkel gnarf mikesherov rwaldron gibson042 timmywil Meetin time! [09:03:44] yup yup [09:03:50] hi [09:04:08] https://docs.google.com/document/d/1MrLFvoxW7GMlH9KK-bwypn77cC98jUnz7sMW1rg_TP4/edit [09:04:16] to save you a few clicks [09:04:16] Hi everyone, I have a delivery for moz/b2g, so I need to skip the meeting today [09:04:18] sorry [09:04:18] <3 [09:04:33] oh good, a scapegoat to drop all the work on! [09:04:58] jQuery 3.0 ships in April, rick's gonna finish it up this week [09:04:59] :D [09:05:35] i am opposed [09:05:58] ok we move it to 4.0 [09:06:05] ok [09:06:09] yay! [09:06:23] ok so i reallllly want to get the next 2.0 beta out this week [09:06:27] before i get swamped again [09:06:49] so this ie9 focus thing is causing lots of issues [09:07:01] john resig sent me an email from their devs [09:07:37] the document.activeElement of death [09:07:41] so, focus + iframes? [09:07:58] so i'm really hesitant to force-focus the document, that seems like a bad idea [09:08:16] it gets rid of the error but seems like it would cause other havoc [09:09:06] SOMETHING had focus before we did that, and now it doesn't [09:10:19] has anyone tried this suggestion? "use document.documentElement.activeElement instead of document.activeElement" [09:10:45] i saw that and meant to check ... [09:10:58] I was wondering that too, but haven't checked [09:11:12] also there's another solution in the approach in http://bugs.jqueryui.com/ticket/8443 might work [09:11:34] but documentElement would be cleaner if it works everywhere [09:11:51] the try/catch solution should be our last option [09:12:26] agreed [09:12:47] try/catch doesn't even work IIRC [09:13:16] i thought it was catchable, but we'd like to avoid them anyway [09:13:27] what about removing the activeElement check? [09:13:44] there are two bugs stemming from it [09:13:49] one is the :active selector [09:13:55] the other is the .focus() method [09:14:04] :active selector was removed [09:14:10] but we do have :focus [09:14:24] oh :focus [09:14:25] yeah [09:14:48] gotcha [09:14:51] i use activeElement for .focus() to see if we are re-focusing [09:15:00] if we are i know it won't actually fire [09:15:14] right, but maybe re-focusing is ok [09:15:19] ? [09:15:21] perhaps? [09:15:43] I still like the documentElement fix if it does in fact work [09:15:48] it's okay but the native DOM .focus() won't fire the handlers then [09:15:57] agreed on documentElement [09:16:19] dgalvez started on a PR for this but we havent' heard from him in a while [09:16:25] agreed, but if that doesn't work, I'm throwing out another option [09:17:05] we pretty much have to fire jQuery handlers on .focus() regardless of whether it's curently focused or not [09:17:09] that's what makes this hard [09:17:20] so we need to know if native focus will do the work for us [09:17:25] or if we have to call them ourselves [09:17:46] or we have to set up a way to detect if they did fire and call them as a last resort [09:17:51] i think gibson042 has a patch for that but it was big [09:18:05] to put it lightly [09:19:02] so focus is a big ball o mess no matter what, and we tried to make it just a little better in 1.9 and it bit us [09:20:14] the documentElement approach seems good if it works everywhere [09:20:27] I just checked Sizzle and :focus is ok with docElem [09:20:35] but I didn't add a test for IE9 or anything [09:21:03] aights, I gotta go to lunch [09:21:05] good [09:21:10] good on the test [09:21:13] and on lunch [09:21:17] thanks :) [09:21:25] I'll go ahead and add a test for IE9 later [09:21:41] and check event.js [09:21:58] ok timmywil so you've got this one? [09:22:04] yup [09:22:07] great! [09:22:46] gibson042 that CSP ticket looked like the unit test might not be working? [09:23:05] for the record, here's the full fix for leveraging native events while still doing our magic: https://github.com/gibson042/jquery/compare/jquery:1.9-stable...13428 [09:23:26] yeah DaveMethvin, we were never 100% confident on that test and it does appear to be broken somehow [09:24:03] okay ... still seems to me that on that particular bug we can't do much, cloning should not trigger CSP [09:24:21] 100% agree [09:24:30] 99.9% agree [09:24:40] ok, really gotta run. bbl! [09:24:43] hey go eat lunch mr 0.1 percent! [09:25:18] also note http://bugs.jquery.com/ticket/13507#comment:3 [09:25:25] are these harmless violations? [09:25:30] oh hi, got lost in time translations [09:25:45] that French standard time [09:26:00] yeah, sun saving thingy [09:26:21] yeah i dunno what is up with CSP [09:26:36] clearly it's not used often enough for people to find these things [09:27:06] i guess i'll close this cantfix but not sure how to deal with the unit test [09:27:20] looks to me like the only consequence (other than a console warning) is a false negative for support.clearCloneStyle [09:28:15] which will just result in an extra background-: inherit inline style in certain edge cases [09:29:18] so maybe all's well [09:29:45] so does CSP just block it from happening but not throw an error? [09:29:54] if so it would be hard to detect [09:30:01] shoot, looking at https://github.com/jquery/jquery/blob/1.9-stable/src/support.js#L142, we won't even have the false negative [09:30:13] DaveMethvin right [09:30:24] CSP prevents the action, but doesn't abort execution [09:30:35] and that test will survive the CSP block [09:30:50] haha right! [09:30:51] as far as I can tell, the *only* issue here is a console warning of no effect [09:31:11] so whatddya know, two rongs make a right! [09:31:15] :D [09:31:24] two rongs have no effect [09:31:38] ok i'll close that [09:34:42] ok next [09:34:44] Migrate [09:35:01] I'll grab this, want to do a 1.2 to come out with the 2.0 beta [09:35:19] that will have all the 1.10 changes [09:36:49] Are there other 1.x vs 2.x changes we need to document? [09:37:09] that would be another thing to mention in the blog post [09:37:24] essentially set expectations about the two being compatible [09:37:29] yes, they are API compatible [09:37:35] no they are not undocumented-compatible [09:37:57] as far as ajax goes, we're as close as possible... the only difference is that you don't need the isLocal madness to deal with local protocols anymore in the 2.x line [09:38:32] given that 2.0 will precede 1.10, we should have a section about *not quite* fulfilling our promise of 1.9/2.0 compatibility, with the list of exceptions and the promise of sweeping them up with 1.10 [09:38:33] and i think a "better superset" is fine [09:39:07] i think we just need to start talking about 1.x vs 2.x [09:39:21] but yeah i'll mention those things [09:39:31] going forward, I completely agree [09:39:32] are we syncing on 1.10 / 2.0 or do we intend to have a 1.10 / 2.1 offset ? [09:39:45] 1.10 and 2.0 [09:39:47] the fact we release 2.0 first confuses me ;) [09:39:51] k [09:39:58] releasing both at once is just hard [09:40:07] yeah, makes sense [09:40:17] and also once 2.0 is real we may need to adjust a few things in 1.10 [09:40:24] especially with the flow of bugs we get at each release because we "forgot something" (tm) [09:40:29] right [09:40:45] or because nobody outside us Tested It [09:41:04] do we test internally now ? ;P [09:41:21] the ui and mobile folks test against git [09:41:33] cheaters! [09:41:42] but they have the same probs we do that people get creative [09:42:05] you mispelled it... it's actually crazy: C R A Z Y :) [09:42:13] ya [09:42:43] okay, well i went through the new tix this morning and nothing interesting stuck out [09:43:00] there are a bunch of pull requests that can land [09:43:18] i can do that tonight [09:43:28] any other things that need doing? [09:44:09] branch names? [09:44:11] What about the jsdom thing shanejonas mentioned? [09:44:31] I like 1.10-stable [09:44:48] gf3 that would be a good rwaldron question, i wanted him to be in that discussion regarding node.js [09:44:59] we can do 1.10-stable [09:45:01] Ahh [09:45:06] should we move to 1.x-stable? [09:45:13] 1.10-stable makes sense [09:45:20] I think we need both [09:45:35] 1.-stable should branch from 1.x [09:45:43] that works for me ... i need to delete the 1.8-stable branch to keep things clean [09:45:46] +1 [09:46:50] trying to envision the tree, would we be committing to 1.x then and cherry-picking to 1.10? [09:47:21] seems like we can work in 1.10-stable [09:47:25] 1.x would be ongoing development [09:47:37] would be my guess [09:47:39] if we have that, we don't even need 1.10 until there's something releaseable [09:48:02] what gibson says [09:48:04] 1.x would be the oldIE-supporting analog of master [09:48:18] but once we do get 1.10.0 then we'll be working in 1.x-stable and picking to 1.10-stable [09:48:33] yes [09:48:44] 1.x is by definition *not* stable [09:49:04] but in some cases also working in master and picking to 2.0-stable [09:49:26] remember when everything was simple? :P [09:49:46] the common cherry picks would be between 1.x and master [09:49:57] we basically just have two active branches, master and 1.x [09:49:59] only those bound for patch releases would go to versioned branches [09:50:02] yes [09:50:58] i'm just not sure that the extra branch for 1.x vs 1.10-stable buys us enough to justify more cherry picking [09:51:19] we aren't going to be working at all on 1.9-stable or 1.11-stable during that time [09:51:23] we could always start with one or the other and find out [09:51:29] so 1.x could essentially be 1.10-stable [09:51:57] i still manage to forget landing in one or the other on a few pull requests [09:52:27] okay, well there's a week or two more before we get to that point afaict anyway [09:52:28] well, I like the idea of it being names 1.x... I'd expect tags to be enough for an equivalent of 1.10-stable or do we expect to cherry-pick before release? Like we changed something but don't release it? [09:53:05] something has to represent jquery-git.js [09:53:06] good point jaubourg, tags on a "1.x" branch will almost certainly cover the way we work [09:53:11] right now that's the tip of 1.9-stable [09:53:26] jquery-git should come from 1.x [09:53:33] i think tags can do the rest [09:53:38] +1 [09:53:44] ok, I'm not that mad after all [09:53:50] +1 [09:53:56] not so fast jaubourg ... :D [09:54:02] ouch [09:54:06] we'll be the judge of that [09:54:25] alright, either of you need some fun things to do? [09:55:00] I've still got open tickets for the next release [09:55:04] that's probably fun enough for now [09:55:06] I have a million things to do at Creative-Area so it would have to be very very fun ;P [09:55:21] but I'm still watching the ajax bugs [09:55:39] desperate that so few of them get enough actionable test cases though [09:55:41] ok, i'll keep plugging away as well, let's aim for a 2.0 beta on thursday [09:55:50] agreed jaubourg they did need some tests [09:55:57] ok see you guys later! [09:56:08] later Dave :) [09:56:26] bye [11:08:43] DaveMethvin: here you go [11:08:58] least I can do ;) [11:09:20] thanks jzaefferer [11:09:37] also ChanServ is your friend [11:09:56] once you registered: /msg ChanServ OP #jquery-meeting [11:09:58] I think [11:55:19] I just use `/cs op #jquery-meeting`