[11:03:00] jlast: ariya ikarienator meeting time [11:03:03] hello everyone! [11:03:46] mikesherov_: would you be willing to take notes this time? [11:03:53] sure [11:04:05] wonderful thanks [11:04:19] let's get started [11:04:25] yup [11:05:40] So, since last time? [11:05:48] meta property is landed [11:05:57] I also fixed the long standing issue with yield [11:06:03] hi AndChat|402864 which I assume is gibson [11:06:08] yes, saw that [11:06:35] I think that's all that happened [11:06:55] at least from my side [11:07:10] expect one more PR from me today [11:07:20] Great [11:07:27] I'm looking for something to pick up [11:07:33] ariya: any suggestions? [11:07:47] to help get us to full es6 that is mid-level difficulty? [11:07:50] once those 2 PRs from me got reviewed and landed, I am trying to handle ES6 identifier (halfway there) [11:08:13] mikesherov_: how about codecov? or even sourceType [11:08:22] https://github.com/jquery/esprima/issues/1159 [11:08:32] I can handle sourceType [11:08:36] sourceType will be a massive patch since it will touch every test fixture's baseline [11:08:57] I can just delete all fixtures and rerun :-) [11:09:03] yup :-) [11:09:20] mikesherov_: also your PR https://github.com/jquery/esprima/pull/1107 is severly outdated with all the most recent changes [11:09:27] probably better to close it and recreate it again [11:09:32] yeah, will do [11:10:04] once I'm done with ES6 identifier, I want to include https://github.com/michaelficarra/everything.js in the test suite [11:10:08] on that, what I'll end up with for the comparison is I'm going to be lenient on the tokenizer mischaracterizing a `keyword` for an identifier [11:10:23] because tokenizer by itself can't fully know without speed penalty [11:10:31] yup [11:10:39] or might as well just compare the raw value [11:10:48] raw value is good too [11:10:56] theoretically, if the scanning is wrong, it won't recognize number as a whole and thus raw value comparison is sufficient [11:11:00] can we get michaelficarra to contribute this himself to esprima? [11:11:28] mikesherov_: it's so simple to integrate everything.js :-) [11:11:32] much harder to make it pass [11:11:41] (but we will, soon) [11:11:53] just looking for ways to get other contributors is all [11:13:12] mikesherov_: https://github.com/jquery/esprima/issues/1210 is also good [11:13:12] if someone wants an easy one [11:13:12] jlast: https://github.com/jquery/esprima/issues/1210 [11:13:12] you up for it? [11:13:12] speaking of which, jlast you here? [11:14:46] I guess not? [11:16:14] hey mike [11:16:14] once es6 identifier is in, should we release this as 2.5? [11:16:14] would be happy to take it [11:16:14] yes, ariya let's [11:16:14] let's release early and often [11:16:14] I like the new pace [11:16:14] +1 [11:16:46] gibson042_: do you have free time yet? [11:16:53] Would love to get you contributing [11:17:03] code on top of the thoughts [11:17:19] actually I think I have an idea that can use your help gibson042_ [11:17:30] Likewise, but probably not before jQuery 3.0 [11:17:32] let me write down clearly and I'll shoot you mikesherov_ and gibson042_ an email first [11:17:33] jlast: any update on test runner btw? [11:17:38] a couple [11:17:40] or at least the beta [11:17:46] sounds good ariya [11:17:55] I took a look at espree's test setup [11:18:02] Please do ariya [11:18:42] there tests are nicely organized with mocha, but the runner still relies on node (shelljs) to load fixtures and tests [11:18:59] right [11:19:13] that manifest idea seems pretty good [11:19:31] i filed a ticket with espree to see if nicholas had any ideas [11:19:38] jlast: would you be open to take a look at karma first? [11:19:38] interesting [11:19:40] but i plan to move forward with the fixture json file [11:19:51] ariya, happy to [11:20:03] Oh, what came of in-person CST talks? [11:20:04] karma still can't list the list of fixture files ariya , right? [11:20:13] could you walk through that approach again [11:20:14] https://github.com/karma-runner/karma-html2js-preprocessor [11:20:14] if you're not familiar with it yet, I think I've written a blog post useful for a quick start [11:20:20] gibson042_: I will publish the results today in the ESTree repo [11:20:25] I've slacking on that [11:20:29] i wasn't sure exactly what it'd get us [11:20:41] jlast: http://ariya.ofilabs.com/2013/10/code-coverage-of-jasmine-tests-using-istanbul-and-karma.html [11:21:08] jlast: the preprocessor will expose the content of each file as an item in an array [11:21:24] jlast: the test runner then needs to execute each one, just like what we have right now with Node.js runner [11:21:53] ahh i see [11:23:09] so, to see if i got it, we'd read the tests/fixtures into memory as something like window.__tests__ [11:23:18] well alright, seems straightforward then [11:23:36] cause then you can start karma with the chrome runner [11:23:42] and you have devtools [11:23:44] this doesn't seem too scary https://github.com/karma-runner/karma-html2js-preprocessor/blob/master/lib/html2js.js [11:27:23] Fiddle with it jlast [11:28:39] yup - will share some findings in channel on friday (should have a chance then) [11:31:06] great [11:31:12] even by next wednesday is great [11:31:21] anyone have anything else for now? [11:31:28] ariya: jlast gibson042_ ? [11:31:32] ikarienator: ? [11:31:37] that's all from me [11:32:09] All set here [11:32:15] good [11:33:14] see you next week folks! [11:33:26] * ariya waves [11:33:38] bye!